C++ Date Validation #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

texodus merged 2 commits into master from date-parser

Jan 23, 2019

Contributor

sc1f commented Jan 23, 2019

Add a date parser on the C++ side that correctly validates date/datetime strings using the iomanip header.

The parser is not called by any running code, nor is it included in CMakeLists.txt.
The header does not include support for milliseconds and timezones, which is fine for string validation but will be problematic for parsing.

Added tests for the date parser, and moved computed column tests into their own describe block.
Fixed the use of now-undefined PSP_ABORT in PSP_VERBOSE_ASSERT2.

sc1f added 2 commits

January 23, 2019 12:07


          Move date validation to C++

103be98

WIP: c++ date_parser

WIP: include custom boost exception handler

use std::get_time instead of boost


          remove date_parser from CMakeLists.txt

0c02710

Member

texodus commented Jan 23, 2019

Thanks for the PR!

texodus merged commit d580705 into master

texodus deleted the date-parser branch

January 23, 2019 19:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet