Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interoperability between CMAKE_BUILD_TYPE and PSP_DEBUG #381

Merged
merged 3 commits into from
Jan 15, 2019
Merged

Interoperability between CMAKE_BUILD_TYPE and PSP_DEBUG #381

merged 3 commits into from
Jan 15, 2019

Conversation

timkpaine
Copy link
Member

CMAKE_BUILD_TYPE is the standard, and is configured in DEBUG or RELEASE. We use PSP_DEBUG in the C++ code to trigger debug statements, and rely on it in cmake to build with debug symbols and without optimizations. This PR lets PSP_DEBUG be set from either the PSP_DEBUG environment variable, or from the CMAKE_BUILD_TYPE flag for cmake.

@timkpaine timkpaine added enhancement Feature requests or improvements C++ labels Jan 14, 2019
@texodus
Copy link
Member

texodus commented Jan 15, 2019

Thanks for the PR - this is a great improvement to the build process!

@texodus texodus merged commit f185dfb into finos:master Jan 15, 2019
@texodus texodus mentioned this pull request Jan 17, 2019
Merged
@timkpaine timkpaine deleted the cpp_release branch November 15, 2019 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C++ enhancement Feature requests or improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @texodus