Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port data_types and get_data_type #336

Merged
merged 2 commits into from
Dec 9, 2018
Merged

Port data_types and get_data_type #336

merged 2 commits into from
Dec 9, 2018

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Dec 7, 2018

  • Port data_types and get_data_type
  • Remove vestigial code in DataParser
  • Add test (skipped) for nasty edge case of upgrading int to float columns

@texodus
Copy link
Member

texodus commented Dec 9, 2018

Thanks for the PR, looks good!

@texodus texodus merged commit 0fa9f56 into master Dec 9, 2018
@texodus texodus deleted the port_data_parser branch December 29, 2018 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sc1f @texodus