New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize ViewPrivate #302

Merged

texodus merged 3 commits into master from ViewPrivate_refactor

Nov 12, 2018

Contributor

sc1f commented Nov 12, 2018

Refactor out DOM manipulation methods
Refactor out CancelTask
Add toggleConfig() on view.js as a public API method for programmatically interacting with the viewer, thus reducing dependency on internal _toggle_config.
Reorder ViewPrivate a little more semantically, with getters at the top followed by update methods. Grouped methods with similar logic/interdependency together.

sc1f added 3 commits

November 9, 2018 21:43


          move show/hide actions to dom.js

a3f5381


          move CancelTask into separate class

e15ea6b


          reorganize ViewPrivate

d9813b2

texodus merged commit f225a57 into master

texodus deleted the ViewPrivate_refactor branch

November 12, 2018 09:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet