Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed workspace persistence structure symmetry #2833

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

texodus
Copy link
Member

@texodus texodus commented Nov 7, 2024

This PR fixes an asymmetry in how <perspective-workspace> serialized layouts created via addViewer vs restore method calls. While this is a breaking change in the context of the workspace API, as this API is not stable (and likely won't be), we're not marking this Issue as breaking.

@texodus texodus force-pushed the workspace-config-udpate branch from f3cbec0 to 36c711c Compare November 7, 2024 05:22
@texodus texodus added the bug Concrete, reproducible bugs label Nov 7, 2024
@texodus texodus marked this pull request as ready for review November 7, 2024 05:40
@texodus texodus force-pushed the workspace-config-udpate branch from 36c711c to 66e48c7 Compare November 7, 2024 06:07
@texodus texodus merged commit 78b2013 into master Nov 7, 2024
13 checks passed
@texodus texodus deleted the workspace-config-udpate branch November 7, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant