Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ABI3 for perspective-python shared library #2661

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Use ABI3 for perspective-python shared library #2661

merged 1 commit into from
Jul 9, 2024

Conversation

texodus
Copy link
Member

@texodus texodus commented Jul 4, 2024 •
edited
Loading

Adds abi3-py39 build target to perspective-python

@texodus texodus mentioned this pull request Jul 6, 2024
Closed
timkpaine
timkpaine requested changes Jul 6, 2024
View reviewed changes
Copy link
Member

@timkpaine timkpaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests/any other places should remove spurious lambdas as in #2667

rust/perspective-python/src/client/client_sync.rs Show resolved Hide resolved
@texodus
Switch to abi3
b08e29c 
Signed-off-by: Andrew Stein <[email protected]>
@texodus
Copy link
Member Author

texodus commented Jul 9, 2024

Fixes #2632

@texodus texodus added the enhancement Feature requests or improvements label Jul 9, 2024
@texodus texodus added this to the 3.0 milestone Jul 9, 2024
@texodus texodus linked an issue Jul 9, 2024 that may be closed by this pull request
Python 3.12 wheels #2632
Closed
@texodus texodus marked this pull request as ready for review July 9, 2024 04:17
@texodus texodus merged commit b827495 into master Jul 9, 2024
4 checks passed
@texodus texodus deleted the psp3-abi3 branch July 9, 2024 04:17
@texodus texodus restored the psp3-abi3 branch July 9, 2024 04:17
@texodus texodus deleted the psp3-abi3 branch July 27, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timkpaine timkpaine timkpaine requested changes

Assignees
No one assigned
Labels
enhancement Feature requests or improvements
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

Python 3.12 wheels
2 participants
@texodus @timkpaine