A few CSS fixes for regular-table in shadow DOM #2526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With regular-table in the rule, the variables won't apply to the computed style lookups used in datagrid because its regular-table is in the shadow DOM. Co-authored-by: Ada Mandala <[email protected]>
tomjakubowski
commented
Feb 6, 2024
| perspective-viewer.dragging regular-table { | ||
| pointer-events: none; | ||
| perspective-viewer.dragging, | ||
| :host-context(perspective-viewer.dragging) { |
There was a problem hiding this comment.
I could use some help with testing this rule. I couldn't find anywhere where dragging is set on the viewer's classes, and various drag/drop operations I tried didn't seem to add the class name to the viewer either
tomjakubowski
commented
Feb 6, 2024
| #efb92d, | ||
| #ed9c25, | ||
| #eb7e20, | ||
| #e75d1e, |
There was a problem hiding this comment.
there were several formatting-only changes like this. I'm not sure how this happened - I have format with save enabled in VSCode, but it should be using the same prettier settings that the linter uses. And the linter accepts it in either style
tomjakubowski
commented
Feb 6, 2024
| @@ -64,7 +64,8 @@ perspective-string-column-style[theme="Monokai"] { | |||
| --rt-neg-cell--color: #ff6188 !important; | |||
| --rt--border-color: #444444; | |||
|
|
|||
| // TODO: probably doesn't work with shadow DOM | |||
| // FIXME: broken in shadow DOM. Can be fixed with a new custom property allowing empty header cell backgrounds | |||
There was a problem hiding this comment.
I took a stab at this, but I couldn't work out how to declare the "default" value for the CSS custom property so that the theme override's was more specific than it
Firefox and Safari do not yet support :host-context()
texodus
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving datagrid's regular-table into shadow DOM caused some CSS regressions. These changes fix a few that we've spotted, particularly in the table header.