Add Docs Tests #2502
Add Docs Tests #2502
Conversation
ada-x64
force-pushed
the
chores/docs-tests
branch
from
43ee1f9 to
cb5750c
Compare
|
We've added HTML reporting to this PR. This allows us to download an artifact containing the results of the test. |
ada-x64
force-pushed
the
chores/docs-tests
branch
2 times, most recently
from
a253939 to
fb317d0
Compare
ada-x64
force-pushed
the
chores/docs-tests
branch
from
4e9dab0 to
679cffa
Compare
|
Another update: |
co-authored by: Ada Mandala <[email protected]>
ada-x64
force-pushed
the
chores/docs-tests
branch
from
ffb1674 to
2cb4073
Compare
fix broken svg comparisons
ada-x64
force-pushed
the
chores/docs-tests
branch
from
2cb4073 to
9cd4eec
Compare
| @@ -157,7 +161,7 @@ export default defineConfig({ | |||
| forbidOnly: !!process.env.CI, | |||
| retries: process.env.CI ? 2 : 0, | |||
| quiet: true, | |||
| reporter: process.env.CI ? "github" : "dot", | |||
| reporter: process.env.CI ? [["github"], ["html"]] : [["dot"]], | |||
| @@ -49,6 +49,11 @@ async function run_with_theme(page, is_dark = false) { | |||
| await page.goto("http://localhost:8080/"); | |||
| await page.setContent(template(is_dark)); | |||
| await page.setViewport(DEFAULT_VIEWPORT); | |||
| await page.evaluate(async () => { | |||
| while (!window.__TEST_PERSPECTIVE_READY__) { | |||
There was a problem hiding this comment.
If __TEST_PERSPECTIVE_READY__ were a Promise, we could just await it here.
| await page.evaluate(async (config) => { | ||
| const viewer = document.querySelector("perspective-viewer"); | ||
| await viewer.reset(); | ||
| await viewer.restore(config); | ||
| }, new_config); | ||
|
|
||
| await page.waitForSelector("perspective-viewer:not([updating])"); |
There was a problem hiding this comment.
What is the story behind this + lines 52-56 in this file?
| with: | ||
| name: playwright-report | ||
| path: tools/perspective-test/playwright-report/ | ||
| retention-days: 30 |
There was a problem hiding this comment.
I will keep an eye on the impact of these artifacts on our GitHub footprint!
Currently on https://perspective.finos.org, there are broken examples on the home page. This occurs on X/Y scatter plots due to a failing migration.
Building and testing on main does not replicate the bug, as the website is running on v2.7.1 and a fix has been added since that release.
This PR simply adds tests for the examples (one for each example, totaling 75) to ensure this doesn't happen again.