Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add index(), col(), and vlookup() to ExprTk #2374

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

timbess
Copy link
Contributor

@timbess timbess commented Oct 5, 2023

This adds index() which returns the primary key of the current row, col('column_name') which is essentially the same as "column_name" except that it takes a string literal, and vlookup('column_name', index) which will lookup a value in a column by primary key such that col('a') == vlookup('a', index()).

@timbess timbess force-pushed the 184899711-new-exprtk-functions branch from b17be52 to dbecf43 Compare October 5, 2023 16:59
@texodus
Copy link
Member

texodus commented Oct 5, 2023

#2041

@timbess timbess force-pushed the 184899711-new-exprtk-functions branch from 530d54c to fc4ba2d Compare October 9, 2023 18:51
@timbess timbess force-pushed the 184899711-new-exprtk-functions branch from fc4ba2d to dbe5431 Compare October 10, 2023 13:55
@timbess timbess marked this pull request as ready for review October 10, 2023 14:58
@timbess timbess force-pushed the 184899711-new-exprtk-functions branch 5 times, most recently from e34d701 to a6e67ad Compare October 12, 2023 15:20
@timbess timbess force-pushed the 184899711-new-exprtk-functions branch from a6e67ad to 4a3989f Compare October 12, 2023 18:23
@texodus
Copy link
Member

texodus commented Oct 13, 2023

take4.mov

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

@texodus texodus added the enhancement Feature requests or improvements label Oct 13, 2023
@texodus texodus merged commit 29ef4d7 into finos:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants