Skip to content

Fix python segfault in multi-threaded execution #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

texodus
Copy link
Member

@texodus texodus commented Jun 30, 2023

Fixes a potential Python segfault introduced in 2.3.0, which can occur when:

  • Perspective is running in async mode via a multi-threaded executor and ...
  • A Table() is constructed via Arrow input and ...
  • Table.update() is called with an Arrow by a separate thread before the previous call has resolved.

See the included test for a repro, which implements a multi-threaded executor then queues 20 read/write Arrow operations at once.

@texodus texodus added the bug Concrete, reproducible bugs label Jun 30, 2023
@texodus texodus merged commit 01e4c9d into master Jun 30, 2023
@texodus texodus deleted the py-segfault-fix branch June 30, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant