Add API to give number of views into table #2267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Killing this for now. |
|
JK 😎 |
|
This should be symmetric in python |
sinistersnare
force-pushed
the
feature/table-subscriber-count
branch
from
45a5a52 to
30df5e3
Compare
|
Good call, added to the Python API. |
texodus
approved these changes
Jun 24, 2023
| @@ -12,7 +12,6 @@ | |||
| #![feature(lazy_cell)] | |||
| #![feature(macro_metavar_expr)] | |||
| #![feature(let_chains)] | |||
| #![feature(anonymous_lifetime_in_impl_trait)] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test describes the usage.
Would it possibly be better so simply give a
get_viewsmethod, that returns each View object? Then we could just calltable.get_views().length.Either way, happy to do it.