Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove umd builds from all packages #2211

Merged
merged 6 commits into from
May 7, 2023
Merged

Remove umd builds from all packages #2211

merged 6 commits into from
May 7, 2023

Conversation

texodus
Copy link
Member

@texodus texodus commented Apr 29, 2023

The intention of this PR is to make perspective easier to use from a bundler, especially webpack.

  • Remove umd builds from all packages. Importing the root package e.g. @finos/perspective now resolves to an inlined build in ES Module (esm) format, and an asset-parallel build in any plugin-assisted bundler script or in the dist/cdn directory. As a result of this change, it is no longer possible to include pre-built perspective directly in an HTML <script> tag without <script type="module">, which is well supported by all browsers. A bundler and plugin (or other) can still produce such output if desired.
  • @finos/perspective-workspace is no longer a supserset of @finos/perspective-viewer, and the latter must now be imported separately (as well as themes).
  • Separates C++ emscripten build into node and web bundles. This makes the build much slower, but to do otherwise (e.g. currently) emscripten's JS output contains both JS (URL()) and node (require("path")) code blocks emitted, which drives some bundlers (e.g. webpack) crazy.
  • Adds missing tests for the @finos/perspective-cli package.
  • Upgrades boost to 1.8.3 and emsdk to 3.1.24.

@texodus texodus merged commit 1c72887 into master May 7, 2023
@texodus texodus deleted the emsdk-update branch May 7, 2023 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking internal Internal refactoring and code quality improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant