Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Yew 0.20.0 #2018

Merged
merged 1 commit into from
Nov 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/perspective-jupyterlab/test/results/results.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"__GIT_COMMIT__": "c744efa438393bf46bf0d0801d9807fd86b64f51",
"__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db",
"resize_Config_should_show_by_default": "f492628efc5ce5c9e1bab910cf2557c9",
"resize_Resize_the_container_causes_the_widget_to_resize": "96a80143ba27bf42cc22d69c4ff1692a",
"resize_group_by_traitlet_works": "f86409c2ccbdf3613a4aa20fc24cc543",
Expand Down
2 changes: 1 addition & 1 deletion packages/perspective-viewer-d3fc/test/results/results.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"__GIT_COMMIT__": "be50bcdfb1c1160ccc560af452db54446386ffcf",
"__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db",
"area_shows_a_grid_without_any_settings_applied": "67bab9ea6654cc7cf7c7b096824e610a",
"area_displays_visible_columns_": "9c195f0f7bf184a4cb9e727f1b37b301",
"area_pivot_by_a_row": "fbae982b73c9cbf91be40a767cbbd3df",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"superstore_displays_visible_columns_": "09dd14f0e60da0e8749b7dd514e929f0",
"superstore_resets_viewable_area_when_the_logical_size_expands_": "e9dd1d275f46f6a0857e0168835d0b38",
"superstore_resets_viewable_area_when_the_physical_size_expands_": "e469597235cc032619bc095a76f9ad6f",
"__GIT_COMMIT__": "ab9e46542b4d70e46e676ed6f39c9ec4828e5715",
"__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db",
"superstore_shows_a_grid_without_any_settings_applied": "192edc6b035af6432c5bd82d295987f1",
"superstore_pivot_by_a_row": "709a4a6b40153d9bf013f90398ee568d",
"superstore_pivot_by_two_rows": "23db46ccf9d8327ae992fe3b5f468b3b",
Expand All @@ -28,6 +28,6 @@
"superstore_filters_filters_by_an_alpha_column": "4b9a40c2ffad050ff4cf059e22cb2b68",
"superstore_filters_filters_with__in__comparator": "5882e2d2694519ba9880d0b2d5b19c44",
"superstore_perspective-config-update_event_is_fired_when_column_style_is_changed": "3d03b2787f9b903050942052168f755a",
"superstore_Column_style_menu_opens_for_numeric_columns": "00994bacd3ef0dec04a14d12c1fa2d0c",
"superstore_Column_style_menu_opens_for_numeric_columns": "fc42b6bd729d72974f1f3c91dee18d8b",
"superstore_Column_style_menu_opens_for_string_columns": "64ca2b3567212ac3b2a5184b7c033db5"
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,5 @@
"superstore_filters_filters_by_a_numeric_column": "80705a191c3675ed34d3058874f09a00",
"superstore_filters_filters_by_an_alpha_column": "80705a191c3675ed34d3058874f09a00",
"superstore_filters_filters_with__in__comparator": "80705a191c3675ed34d3058874f09a00",
"__GIT_COMMIT__": "be50bcdfb1c1160ccc560af452db54446386ffcf"
"__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db"
}
2 changes: 1 addition & 1 deletion packages/perspective-workspace/test/results/results.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"__GIT_COMMIT__": "0d5624d88d56d51c0d034ec07f665c4f06581044",
"__GIT_COMMIT__": "ef6df703f94bdda20d81b476d8725782904357db",
"index_restore_workspace_with_detail_only": "d24f601369fbf86c853d4dd2894506e3",
"index_Light_DOM_restore_workspace_with_detail_only": "e23bd42ed74c5efc2d067301b449027d",
"index_Shadow_DOM_restore_workspace_with_detail_only": "aa44cdf6689ff93f68d4a4cffe292e09",
Expand Down
113 changes: 65 additions & 48 deletions rust/perspective-viewer/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion rust/perspective-viewer/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ wasm-bindgen = { version = "=0.2.82", features = ["serde-serialize"] }
wasm-bindgen-futures = "0.4.20"

# https://github.com/yewstack/yew/issues/2154
yew = { git = "https://github.com/yewstack/yew", rev = "7438cd3059d58d0922e4c15135961c8fab6f2552", features = ["csr"] }
yew = { version = "0.20.0", features = ["csr"] }

[dependencies.web-sys]
version = "0.3.59"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ impl Component for ActiveColumn {
}
}

fn changed(&mut self, ctx: &Context<Self>) -> bool {
fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
self.column_type = ctx.props().get_type();
self.is_required = ctx.props().get_is_required();
true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ impl Component for AggregateSelector {
}
}

fn changed(&mut self, ctx: &Context<Self>) -> bool {
fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
self.aggregates = self.get_dropdown_aggregates(ctx);
true
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ impl Component for ConfigSelector {

/// Should not render on change, as this component only depends on service
/// state.
fn changed(&mut self, _ctx: &Context<Self>) -> bool {
fn changed(&mut self, _ctx: &Context<Self>, _old: &Self::Properties) -> bool {
false
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ impl Component for FilterItem {
}
}

fn changed(&mut self, ctx: &Context<Self>) -> bool {
fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
if let Some(input) = ctx.props().get_filter_input() {
self.input = input;
true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ where
}
}

fn changed(&mut self, _ctx: &Context<Self>) -> bool {
fn changed(&mut self, _ctx: &Context<Self>, _old: &Self::Properties) -> bool {
true
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ where
false
}

fn changed(&mut self, ctx: &Context<Self>) -> bool {
fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
self.selected = ctx.props().selected.clone();
true
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ where
/// If the new total row height is different than last time this component
/// was rendered, we need to double-render to read the container's
/// potentially updated height.
fn changed(&mut self, ctx: &Context<Self>) -> bool {
fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
let total_height = ctx.props().total_height(ctx);
self.needs_rerender =
self.needs_rerender || (self.total_height - total_height).abs() > 0.1f64;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ where
}

// The `<select>` has its own state not refelcted by `SelectProps`.
fn changed(&mut self, ctx: &Context<Self>) -> bool {
fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
self.selected = ctx.props().selected.clone();
true
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ impl Component for SplitPanel {
}
}

fn changed(&mut self, ctx: &Context<Self>) -> bool {
fn changed(&mut self, ctx: &Context<Self>, _old: &Self::Properties) -> bool {
assert!(ctx.props().validate());
let new_len = ctx.props().children.len();
self.refs.resize(new_len, Default::default());
Expand Down
Loading