Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fire config-update evnt on d3fc updates #1732

Closed
wants to merge 1 commit into from

Conversation

jkusa
Copy link
Contributor

@jkusa jkusa commented Mar 2, 2022

This PR resolves #1729 and also fires the perspective-config-update event when updates are made to the d3fc legend position.

@jkusa jkusa force-pushed the d3fc-events branch 2 times, most recently from daf9e8d to 9e69fd6 Compare March 7, 2022 21:14
@jkusa jkusa marked this pull request as ready for review March 7, 2022 21:19
@texodus
Copy link
Member

texodus commented Mar 9, 2022

Thanks for the PR and the tests @jkusa! Much appreciated!

There are a few changes that I needed to make, so I've opened a new PR with these fixes in #1748 which includes these commits as well. Closing this one in preference to #1748

@texodus texodus closed this Mar 9, 2022
@jkusa
Copy link
Contributor Author

jkusa commented Mar 9, 2022

Sounds good, thanks @texodus!

@jkusa jkusa deleted the d3fc-events branch March 9, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fire perspective-config-update on axis switch for multi-axis charts
2 participants