Skip to content

add missing definition for re2 on os x to reenable conda builds #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 9, 2021

Conversation

timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine added internal Internal refactoring and code quality improvement Python labels Dec 7, 2021
@timkpaine timkpaine marked this pull request as ready for review December 8, 2021 04:44
Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good!

elseif(x86_64Supported)
set(CMAKE_REQUIRED_LINK_OPTIONS "-arch;x86_64")
set(CMAKE_OSX_ARCHITECTURES "x86_64" CACHE STRING "Build universal architecture for OSX" FORCE)
elseif(arm64Supported)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a conda target for just arm64?!

@texodus texodus merged commit 8728ad6 into finos:master Dec 9, 2021
@timkpaine timkpaine deleted the tkp/re2fix branch April 4, 2022 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Internal refactoring and code quality improvement Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants