Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'weighted mean' aggregate support in <perspective-viewer> #1543

Merged
merged 20 commits into from
Sep 21, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Sep 19, 2021

New implementations:

  • Reimplements weighted mean" aggregate type in new ` UI
  • Reimplements delete() for <perspective-viewer>

Fixes:

  • Fixes default column selection for Chart plugins with minimum column requirements, such as 'X/Y Scatter'. When applied to a dataset with zero or too-few numeric columns, this logic would fail and select all columns instead, rather than choosing a minimum of non-numeric columns as a second choice.
  • Fixes date/datetime filter validation, which would previously not allow invalid date or datetimes to be typed, like 1/1/0201, even if they were intermediate states while typing a full date like 1/1/2016.
  • Fixes editable support in perspective-workspace, which while no longer a config variable for <perspective-viewer>, will remain in <perspective-workspace> for the time being.
  • Fixes open_table() client method in JavaScript to return a Promise, making it consistent with other proxy-returning functions in the perspective API.
  • Fixes filter and various other top-panel controls to pull theme variables rather than hardcode colors.
  • Fixes bug which caused column selector to not re-render when the column list does not update, e.g. when changing from 'X Bar" to "Datagrid", which left the top column selector greyed-out until render was forced.
  • Fixes columns so they are removed from the active column list when drag/dropped to a pivot position.
  • Fixes CSS dimensional properties like position to be consistent and simplified between themes.
  • Fixes lint to apply to examples and cpp, and auto-applies fixes as "no author".
  • Fixes a bug which caused the plugin-config dropdown to not update after a call to restore() (though the plugin itself does switch and render correctly).
  • Fixes theme variables which apply to modal to be properly instantiated, e.g. for moncao.
  • Fixes <perspective-workspace> persistence for attribute-preserved settings like selectable.
  • Fixes filter dropdowns to consistently open targetting the correct filter, which would drift when the settings control was toggled.
  • Fixes perspective-webpack-plugin to correctly outline dynamic imports when inline: false.

@texodus texodus force-pushed the weighted-mean-2 branch 3 times, most recently from ec8a419 to 29d87e3 Compare September 19, 2021 02:42
@texodus texodus marked this pull request as ready for review September 19, 2021 05:42
@texodus texodus force-pushed the weighted-mean-2 branch 2 times, most recently from 841da4f to f25980b Compare September 19, 2021 21:31
@texodus texodus merged commit 5a6d0cf into master Sep 21, 2021
@texodus texodus deleted the weighted-mean-2 branch September 21, 2021 20:27
@texodus texodus added the bug Concrete, reproducible bugs label Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Concrete, reproducible bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant