Remove webpack as a peerDependency for the webpack plugin #1311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes webpack as a peerDependency for `@finos/perspective-webpack-plugin` A peer dependency (or dependency) should only be included if it's actually required by the source code. (For the same reason, `file-loader` and `worker-loader` _should_ be included because they're implicitly required.) Keeping this peerDependency makes it so that the consuming package has to declare webpack as a dependency, even if they're only passing the plugin to a tool that transitively uses webpack.
texodus
approved these changes
Feb 1, 2021
texodus
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes webpack as a peerDependency for
@finos/perspective-webpack-pluginIMO, a peer dependency (or dependency) should only be included if it's actually required by the source code. (For the same reason,
file-loaderandworker-loadershould be included because they're implicitly required.) Keeping this peerDependency makes it so that the consuming package has to declare webpack as a dependency, even if they're only passing the plugin to a tool that transitively uses webpack.