Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: version conflict that makes npm install failed #1266

Merged
merged 1 commit into from
Dec 30, 2020

Conversation

damphat
Copy link
Contributor

@damphat damphat commented Dec 25, 2020

Fix: version conflict that makes npm install failed
Reason: [email protected] require depends on [email protected]

Bug reproduction:

dependencies: {
    "@finos/perspective": "^0.5.6",
    "@finos/perspective-webpack-plugin": "^0.5.6",
}
> npm install
npm ERR! Could not resolve dependency:
npm ERR! peer @finos/perspective@"^0.4.2" from @finos/[email protected]
npm ERR! node_modules/@finos/perspective-webpack-plugin
npm ERR!   @finos/perspective-webpack-plugin@"^0.5.6" from the root project

Fix: version conflict that makes `npm install` failed
Reason: [email protected] require depends on [email protected]

Bug reproduction:
```
dependencies: {
    "@finos/perspective": "^0.5.6",
    "@finos/perspective-webpack-plugin": "^0.5.6",
}
```
```bash
> npm install
npm ERR! Could not resolve dependency:
npm ERR! peer @finos/perspective@"^0.4.2" from @finos/[email protected]
npm ERR! node_modules/@finos/perspective-webpack-plugin
npm ERR!   @finos/perspective-webpack-plugin@"^0.5.6" from the root project
```
@finos-cla-bot
Copy link

finos-cla-bot bot commented Dec 25, 2020

Thank you for your contribution and Welcome to our Open Source Community!

To make sure your pull request is accepted successfully, we ask all our open source contributors to sign a Contributor License Agreement.

Having reviewed our contributor list, we require a CLA for the following people : (@damphat).

If you need help obtaining a CLA, please read the Requirements for Contributions section of our CLA wiki or email [email protected] with your questions.

Thanks once again for your contribution. Let us work with you to make the CLA process quick, easy and efficient so we can move forward with reviewing and accepting your pull request.

cc @finos-admin

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the PR!

This fails to be auto-updated by lerna without --force-publish, which itself seems like overkill since this package rarely if ever changes. I'm open to any suggestions on better ways to handle this, a few possibilities I can think of:

  • Add a prod task for scripted production builds which calls this command, and perhaps eventually publish automatically from github actions or azure. We've discussed this orthogonally to Webpack integration.
  • Remove peerDependencies entirely. Unless we significantly change the file/load architecture, this package should be compatible with all future perspective versions anyway.
  • Merge this package with @finos/perspective.
  • Remove Perspective's custom .wasm loading mechanism entirely, and rely on webpack 4's existing wasm support. I think this is the most promising, but will require a bit of research to familiarize with the latest Emscripten/Webpack best practices.

@texodus texodus merged commit 70c8f68 into finos:master Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants