Skip to content

Cleans up CMakeLists & Python build scripts, fixes datetime string rendering #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 24, 2020

Conversation

sc1f
Copy link
Contributor

@sc1f sc1f commented Jun 18, 2020

This PR cleans up the Python build by removing vestigial code in CMakeLists and refactoring build scripts, as well as fixes to datetime handling:

  • Streamlines CMakeLists & Python build/test scripts
    • Removes boost.filesystem from required dependencies
    • makes find_package(Boost) required for Python build
    • tests the selected python command before running, and defaults to python if the selected command (python3.7) etc. is not found
    • Refactors test_python.js
  • Fixes Incorrect Values Rendered with uint8 Column on Datagrid #1084 - the full set of type interactions when updating Table with an arrow is now mapped out and tested.
  • Replaces put_time with strftime using a 64-char string buffer
    • The maximum datestring that can be printed (10000-01-01 12:34:56:999999) is 27 chars, so this can be optimized a little further probably
    • if strftime fails, print the date in UTC using date.h as a fallthrough.

@sc1f sc1f self-assigned this Jun 18, 2020
@sc1f sc1f added C++ internal Internal refactoring and code quality improvement Python labels Jun 18, 2020
@timkpaine
Copy link
Member

@sc1f this should probably go on top of #1057 or we're gonna have one hell of a conflict to clean up haha

@sc1f
Copy link
Contributor Author

sc1f commented Jun 24, 2020

@texodus this branch is on top of the changes in #1077 - hence the large number of commits. 067f70c onwards are the unique changes

Copy link
Member

@texodus texodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@texodus texodus merged commit 712f4c0 into master Jun 24, 2020
@texodus texodus deleted the cmake-fix branch June 24, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ internal Internal refactoring and code quality improvement Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect Values Rendered with uint8 Column on Datagrid
4 participants