Remove duplicate psp_okey column from arrow updates
#1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
approved these changes
May 13, 2020
| @@ -1064,7 +1064,8 @@ namespace binding { | |||
|
|
|||
| // Always use the `Table` column names and data types on up | |||
| if (table_initialized && is_update) { | |||
| auto schema = gnode->get_output_schema(); | |||
| auto gnode_output_schema = gnode->get_output_schema(); | |||
| auto schema = gnode_output_schema.drop({"psp_okey"}); | |||
There was a problem hiding this comment.
It is amazing to me that this coerces to std::set<std::string> ..
Since column_names is simply iterated on 10loc below this, it may be cheaper to simple continue on "psp_okey", since drop() iterates through the set and reconstructs both name and type vectors from scratch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reproduces and fixes a segmentation fault with arrow updates and string reallocation - previously, the
psp_okeycolumn was being duplicated incorrectly on an Arrow update, and this turned out to be the cause of a few different segfaults that became trivially reproducible (and has been reproduced and tested in the Python tests).Removing the incorrect duplication fixes the tests and seems to (for now) prevented any further segfaults related to this issue.