Skip to content

Commit

Permalink
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Clean JS dependencies
Browse files Browse the repository at this point in the history
texodus committed Jan 10, 2023
1 parent 524e560 commit fb6a541
Showing 37 changed files with 158 additions and 132 deletions.
5 changes: 1 addition & 4 deletions cpp/perspective/package.json
Original file line number Diff line number Diff line change
@@ -11,9 +11,6 @@
],
"scripts": {
"build": "node ../../scripts/run_emsdk.js node ./build.js",
"clean": "rimraf dist",
"test": ":",
"test:run": ":",
"test:build": ":"
"clean": "rimraf dist"
}
}
1 change: 0 additions & 1 deletion docs/package.json
Original file line number Diff line number Diff line change
@@ -5,7 +5,6 @@
"scripts": {
"docusaurus": "docusaurus",
"start": "docusaurus start",
"build": ":",
"docs": "docusaurus build",
"swizzle": "docusaurus swizzle",
"deploy": "docusaurus deploy",
2 changes: 2 additions & 0 deletions examples/blocks/package.json
Original file line number Diff line number Diff line change
@@ -14,6 +14,8 @@
"@finos/perspective-viewer": "^1.9.0",
"@finos/perspective-viewer-d3fc": "^1.9.0",
"@finos/perspective-viewer-datagrid": "^1.9.0",
"@finos/perspective-viewer-openlayers": "^1.9.0",
"@finos/perspective-workspace": "^1.9.0",
"superstore-arrow": "1.0.0"
}
}
1 change: 1 addition & 0 deletions examples/esbuild-example/build.js
Original file line number Diff line number Diff line change
@@ -12,6 +12,7 @@ async function build() {
outdir: "dist",
format: "esm",
bundle: true,
target: "es2020",
loader: {
".ttf": "file",
".arrow": "file",
3 changes: 2 additions & 1 deletion examples/esbuild-example/package.json
Original file line number Diff line number Diff line change
@@ -14,7 +14,8 @@
"@finos/perspective-viewer": "^1.9.0",
"@finos/perspective-viewer-d3fc": "^1.9.0",
"@finos/perspective-viewer-datagrid": "^1.9.0",
"@finos/perspective-viewer-openlayers": "^1.9.0"
"@finos/perspective-viewer-openlayers": "^1.9.0",
"superstore-arrow": "^1.0.0"
},
"devDependencies": {
"@finos/perspective-esbuild-plugin": "^1.9.0",
8 changes: 0 additions & 8 deletions examples/promo/webpack.config.js
Original file line number Diff line number Diff line change
@@ -34,14 +34,6 @@ module.exports = {
test: /\.css$/,
use: [{ loader: "style-loader" }, { loader: "css-loader" }],
},
{
test: /\.less$/,
use: [
{ loader: "style-loader" },
{ loader: "css-loader" },
{ loader: "less-loader" },
],
},
{
test: /\.(png|jpe?g|gif)$/i,
type: "asset/resource",
2 changes: 1 addition & 1 deletion examples/webpack-cross-origin/package.json
Original file line number Diff line number Diff line change
@@ -25,6 +25,6 @@
"style-loader": "^0.18.2",
"webpack": "^5.14.0",
"webpack-cli": "^4.3.1",
"webpack-dev-server": "^3.11.2"
"webpack-dev-server": "^4.11.1"
}
}
2 changes: 1 addition & 1 deletion examples/webpack-example/package.json
Original file line number Diff line number Diff line change
@@ -22,6 +22,6 @@
"style-loader": "^0.18.2",
"webpack": "^5.14.0",
"webpack-cli": "^4.3.1",
"webpack-dev-server": "^3.11.2"
"webpack-dev-server": "^4.11.1"
}
}
8 changes: 4 additions & 4 deletions examples/webpack-example/src/index.js
Original file line number Diff line number Diff line change
@@ -21,15 +21,15 @@ const worker = perspective.shared_worker();

// superstore.arrow located in node_modules/superstore-arrow/ and it's
// configured by 'devServer' in 'webpack.config.js'
// const req = fetch("./superstore.arrow");
const req = fetch("./superstore.arrow");

window.addEventListener("DOMContentLoaded", async () => {
const viewer = document.createElement("perspective-viewer");
document.body.append(viewer);

// const resp = await req;
// const buffer = await resp.arrayBuffer();
const table = worker.table({ x: [1, 2, 3, 4, 5] });
const resp = await req;
const buffer = await resp.arrayBuffer();
const table = worker.table(buffer);

viewer.load(table);

2 changes: 1 addition & 1 deletion examples/webpack-example/webpack.config.js
Original file line number Diff line number Diff line change
@@ -40,7 +40,7 @@ module.exports = {
entrypoints: false,
},
devServer: {
contentBase: [
static: [
path.join(__dirname, "dist"),
path.join(__dirname, "../../node_modules/superstore-arrow"),
],
8 changes: 5 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@
"type": "git",
"url": "https://github.com/finos/perspective"
},
"version": "1.9.0",
"changelog": {
"labels": {
"enhancement": "Added",
@@ -29,13 +30,14 @@
"packages/perspective-jupyterlab",
"packages/perspective-webpack-plugin",
"packages/perspective-cli",
"examples/blocks",
"examples/*",
"docs",
"python/perspective"
],
"devDependencies": {
"@types/ws": "^7.2.2",
"arraybuffer-loader": "^1.0.2",
"auto-changelog": "^2.4.0",
"chalk": "^2.4.2",
"cpy-cli": "^3.1.1",
"css-loader": "^0.28.7",
@@ -130,7 +132,7 @@
"test_js": "node scripts/test_js.js",
"test_python": "node scripts/test_python.js",
"clean": "node scripts/clean.js",
"start": "lerna run start --stream --scope",
"start": "npm run start --workspace",
"prepush": "npm-run-all lint_js lint_python",
"prepare": "husky install",
"lint_js": "npm-run-all lint:*",
@@ -145,7 +147,7 @@
"fix:json": "prettier --write packages/**/package.json rust/**/package.json examples/**/package.json docs/package.json",
"fix:python": "node scripts/lint_python.js --fix",
"fix": "npm-run-all --silent fix:*",
"version": "python3 python/perspective/scripts/write_version.py && git add python/perspective/perspective/core/_version.py && node scripts/version.js",
"version": "node scripts/version.js && python3 python/perspective/scripts/write_version.py && git add python/perspective/perspective/core/_version.py",
"jlab_link": "node scripts/jlab_link.js",
"repl": "node scripts/repl.js"
}
1 change: 0 additions & 1 deletion packages/perspective-cli/package.json
Original file line number Diff line number Diff line change
@@ -12,7 +12,6 @@
],
"typings": "index.d.ts",
"scripts": {
"build": ":",
"clean": "rimraf build"
},
"repository": {
5 changes: 0 additions & 5 deletions packages/perspective-esbuild-plugin/package.json
Original file line number Diff line number Diff line change
@@ -12,11 +12,6 @@
"*.js",
"README.md"
],
"scripts": {
"build": "echo",
"test": "echo",
"clean": "echo"
},
"repository": {
"type": "git",
"url": "https://github.com/finos/perspective/packages/perspective-build"
9 changes: 6 additions & 3 deletions packages/perspective-esbuild-plugin/umd.js
Original file line number Diff line number Diff line change
@@ -4,11 +4,14 @@ const get_banner = ({ globalName }) => ({
if (typeof define === 'function' && define.amd) {
define(['exports'], factory);
} else if (typeof exports === 'object' && typeof exports.nodeName !== 'string') {
factory(exports);
factory(exports, module);
} else {
factory((root.${globalName} = {}));
const exports = (root.${globalName} = {});
const module = {exports}
factory(exports, module);
root.${globalName} = module.exports;
}
}(typeof self !== 'undefined' ? self : this, function (exports) {
}(typeof self !== 'undefined' ? self : this, function (exports, module) {
`.trimStart(),
});

39 changes: 24 additions & 15 deletions packages/perspective-esbuild-plugin/wasm.js
Original file line number Diff line number Diff line change
@@ -1,30 +1,37 @@
const fs = require("fs");
const path = require("path");

exports.WasmPlugin = function WasmPlugin(inline) {
function setup(build) {
build.onResolve(
{ filter: /^\@finos\/perspective.+?\.wasm$/ },
(args) => {
if (
args.namespace === "wasm-stub" ||
args.namespace === "wasm-inline"
) {
return {
path: args.path,
namespace: "wasm",
};
}
build.onResolve({ filter: /\.wasm$/ }, (args) => {
if (
args.namespace === "wasm-stub" ||
args.namespace === "wasm-inline"
) {
const entryPoint = path.join(
args.pluginData.resolveDir,
args.path
);

return {
path: args.path,
namespace: inline ? "wasm-inline" : "wasm-stub",
path: entryPoint,
namespace: "wasm",
};
}
);

return {
path: args.path,
namespace: inline ? "wasm-inline" : "wasm-stub",
pluginData: {
resolveDir: args.resolveDir,
},
};
});

build.onLoad(
{ filter: /.*/, namespace: "wasm-inline" },
async (args) => ({
pluginData: args.pluginData,
contents: `
import wasm from ${JSON.stringify(args.path)};
export default Promise.resolve(wasm);
@@ -35,6 +42,7 @@ exports.WasmPlugin = function WasmPlugin(inline) {
build.onLoad(
{ filter: /.*/, namespace: "wasm-stub" },
async (args) => ({
pluginData: args.pluginData,
contents: `
import wasm from ${JSON.stringify(args.path)};
async function get_wasm() {
@@ -50,6 +58,7 @@ exports.WasmPlugin = function WasmPlugin(inline) {
const path = require.resolve(args.path);
const contents = await fs.promises.readFile(path);
return {
pluginData: args.pluginData,
contents,
loader: inline ? "binary" : "file",
};
71 changes: 39 additions & 32 deletions packages/perspective-esbuild-plugin/worker.js
Original file line number Diff line number Diff line change
@@ -7,49 +7,55 @@ exports.WorkerPlugin = function WorkerPlugin(options = {}) {
const inline = !!options.inline;
const targetdir = options.targetdir || "build/worker";
function setup(build) {
build.onResolve(
{ filter: /^(\@finos\/perspective).+?worker\.js$/ },
(args) => {
if (args.namespace === "worker-stub") {
const outfile = `${targetdir}/` + path.basename(args.path);
const subbuild = esbuild.build({
target: ["es2021"],
entryPoints: [require.resolve(args.path)],
outfile,
define: {
global: "self",
},
plugins: [EmptyPlugin(["fs", "path"])],
entryNames: "[name]",
chunkNames: "[name]",
assetNames: "[name]",
minify: !process.env.PSP_DEBUG,
bundle: true,
sourcemap: false,
});

return {
path: args.path,
namespace: "worker",
pluginData: {
outfile,
subbuild,
},
};
}
build.onResolve({ filter: /\.worker\.js$/ }, (args) => {
if (args.namespace === "worker-stub") {
const outfile = `${targetdir}/` + path.basename(args.path);
const entryPoint = path.join(
args.pluginData.resolveDir,
args.path
);

const subbuild = esbuild.build({
target: ["es2021"],
entryPoints: [entryPoint],
outfile,
define: {
global: "self",
},
plugins: [EmptyPlugin(["fs", "path"])],
entryNames: "[name]",
chunkNames: "[name]",
assetNames: "[name]",
minify: !process.env.PSP_DEBUG,
bundle: true,
sourcemap: false,
});

return {
path: args.path,
namespace: "worker-stub",
namespace: "worker",
pluginData: {
outfile,
subbuild,
},
};
}
);

return {
path: args.path,
namespace: "worker-stub",
pluginData: {
resolveDir: args.resolveDir,
},
};
});

build.onLoad(
{ filter: /.*/, namespace: "worker-stub" },
async (args) => {
if (inline) {
return {
pluginData: args.pluginData,
contents: `
import worker from ${JSON.stringify(args.path)};
function make_host(a, b) {
@@ -103,6 +109,7 @@ exports.WorkerPlugin = function WorkerPlugin(options = {}) {
}

return {
pluginData: args.pluginData,
contents: `
import worker from ${JSON.stringify(args.path)};
async function get_worker_code() {
3 changes: 2 additions & 1 deletion packages/perspective-jupyterlab/package.json
Original file line number Diff line number Diff line change
@@ -43,7 +43,8 @@
},
"devDependencies": {
"@finos/perspective-esbuild-plugin": "^1.9.0",
"@finos/perspective-test": "^1.9.0"
"@finos/perspective-test": "^1.9.0",
"@prospective.co/procss": "^0.1.8"
},
"jupyterlab": {
"extension": true
22 changes: 21 additions & 1 deletion packages/perspective-jupyterlab/src/js/view.js
Original file line number Diff line number Diff line change
@@ -7,13 +7,33 @@
*
*/

import { isEqual } from "underscore";
import { DOMWidgetView } from "@jupyter-widgets/base";
import { PerspectiveJupyterWidget } from "./widget";
import { PerspectiveJupyterClient } from "./client";

import perspective from "@finos/perspective/dist/esm/perspective.js";

function isEqual(a, b) {
if (a === b) return true;
if (typeof a != "object" || typeof b != "object" || a == null || b == null)
return false;

let keysA = Object.keys(a),
keysB = Object.keys(b);

if (keysA.length != keysB.length) return false;
for (let key of keysA) {
if (!keysB.includes(key)) return false;
if (typeof a[key] === "function" || typeof b[key] === "function") {
if (a[key].toString() != b[key].toString()) return false;
} else {
if (!isEqual(a[key], b[key])) return false;
}
}

return true;
}

/**
* `PerspectiveView` defines the plugin's DOM and how the plugin interacts with
* the DOM.
4 changes: 0 additions & 4 deletions packages/perspective-viewer-datagrid/package.json
Original file line number Diff line number Diff line change
@@ -19,14 +19,10 @@
],
"types": "index.d.ts",
"scripts": {
"bench": "npm-run-all bench:build bench:run",
"bench:build": ":",
"bench:run": ":",
"build": "node build.js",
"test:build": "cpy \"test/html/*\" dist/umd",
"test:run": "jest --rootDir=. --config=../../tools/perspective-test/jest.config.js --color",
"test": "npm-run-all test:build test:run",
"watch": ":",
"clean": "rimraf dist",
"clean:screenshots": "rimraf \"test/screenshots/**/*.@(failed|diff).png\""
},
8 changes: 4 additions & 4 deletions packages/perspective-viewer-openlayers/package.json
Original file line number Diff line number Diff line change
@@ -21,23 +21,23 @@
"access": "public"
},
"scripts": {
"bench": "npm-run-all bench:build bench:run",
"bench:build": ":",
"bench:run": ":",
"build": "node build.js",
"test:build": "cpy \"test/html/*\" dist/umd",
"test:run": "jest --rootDir=. --config=../../tools/perspective-test/jest.config.js --color",
"test": "npm-run-all test:build test:run",
"watch": ":",
"clean": "rimraf dist",
"clean:screenshots": "rimraf \"test/screenshots/**/*.@(failed|diff).png\""
},
"dependencies": {
"@finos/perspective": "^1.9.0",
"@finos/perspective-viewer": "^1.9.0",
"d3": "^7.1.1",
"d3-color": "^3.0.1",
"gradient-parser": "1.0.2",
"less": "^4.1.0",
"ol": "^5.3.2"
},
"devDependencies": {
"@finos/perspective-esbuild-plugin": "^1.9.0"
}
}
1 change: 0 additions & 1 deletion packages/perspective-webpack-plugin/index.js
Original file line number Diff line number Diff line change
@@ -10,7 +10,6 @@
const { get_config } = require("@finos/perspective");
const path = require("path");
const webpack = require("webpack");
const cssnano = require("cssnano");

class PerspectiveWebpackPlugin {
constructor(options = {}) {
6 changes: 2 additions & 4 deletions packages/perspective-webpack-plugin/package.json
Original file line number Diff line number Diff line change
@@ -10,10 +10,6 @@
"src/**/*",
"index.js"
],
"scripts": {
"build": ":",
"clean": ":"
},
"jest": {},
"repository": {
"type": "git",
@@ -22,6 +18,8 @@
"author": "",
"license": "Apache-2.0",
"dependencies": {
"@finos/perspective": "^1.9.0",
"@finos/perspective-viewer": "^1.9.0",
"arraybuffer-loader": "^1.0.2",
"css-loader": "^0.28.7",
"cssnano": "^4.1.10",
3 changes: 1 addition & 2 deletions packages/perspective-workspace/src/js/workspace/workspace.js
Original file line number Diff line number Diff line change
@@ -18,7 +18,6 @@ import { createCommands } from "./commands";
import { PerspectiveViewerWidget } from "./widget";
import uniqBy from "lodash/uniqBy";
import debounce from "lodash/debounce";
import cloneDeep from "lodash/cloneDeep";

const DEFAULT_WORKSPACE_SIZE = [1, 3];

@@ -212,7 +211,7 @@ export class PerspectiveWorkspace extends SplitPanel {
detail,
viewers: viewer_configs = [],
mode = MODE.GLOBAL_FILTERS,
} = cloneDeep(value);
} = structuredClone(value);
this.mode = mode;

if (
1 change: 0 additions & 1 deletion packages/perspective/build.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
const cpy = require("cpy");
const { WorkerPlugin } = require("@finos/perspective-esbuild-plugin/worker");
const {
NodeModulesExternal,
} = require("@finos/perspective-esbuild-plugin/external");
3 changes: 2 additions & 1 deletion packages/perspective/package.json
Original file line number Diff line number Diff line change
@@ -53,6 +53,7 @@
"jsverify": "^0.8.4",
"lodash": "^4.17.4",
"moment": "^2.19.1",
"papaparse": "^5.2.0"
"papaparse": "^5.2.0",
"superstore-arrow": "^1.0.0"
}
}
28 changes: 13 additions & 15 deletions packages/perspective/src/js/config/index.js
Original file line number Diff line number Diff line change
@@ -7,25 +7,25 @@
*
*/

const DEFAULT_CONFIG = require("./settings.js").default;
import DEFAULT_CONFIG from "./settings.js";

module.exports.get_types = function () {
return Object.keys(module.exports.get_config().types);
};
export function get_types() {
return Object.keys(get_config().types);
}

module.exports.get_type_config = function (type) {
export function get_type_config(type) {
const config = {};
if (module.exports.get_config().types[type]) {
Object.assign(config, module.exports.get_config().types[type]);
if (get_config().types[type]) {
Object.assign(config, get_config().types[type]);
}
if (config.type) {
const props = module.exports.get_type_config(config.type);
const props = get_type_config(config.type);
Object.assign(props, config);
return props;
} else {
return config;
}
};
}

function isObject(item) {
return item && typeof item === "object" && !Array.isArray(item);
@@ -49,21 +49,19 @@ function mergeDeep(target, ...sources) {
return mergeDeep(target, ...sources);
}

globalThis.__PERSPECTIVE_CONFIG__ = undefined;

module.exports.override_config = function (config) {
export function override_config(config) {
if (globalThis.__PERSPECTIVE_CONFIG__) {
console.warn("Config already initialized!");
}
globalThis.__PERSPECTIVE_CONFIG__ = mergeDeep(DEFAULT_CONFIG, config);
};
}

module.exports.get_config = function get_config() {
export function get_config() {
if (!globalThis.__PERSPECTIVE_CONFIG__) {
globalThis.__PERSPECTIVE_CONFIG__ = mergeDeep(
DEFAULT_CONFIG,
globalThis.__TEMPLATE_CONFIG__ || {}
);
}
return globalThis.__PERSPECTIVE_CONFIG__;
};
}
2 changes: 1 addition & 1 deletion packages/perspective/src/js/config/settings.js
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@
/**
* The default settings which populate `perspective.config.js`.
*/
module.exports.default = {
export default {
/**
* `types` are the type-specific configuration options. Each key is the
* name of a perspective type; their values are configuration objects for
4 changes: 2 additions & 2 deletions packages/perspective/src/js/perspective.browser.js
Original file line number Diff line number Diff line change
@@ -15,8 +15,8 @@ import { WebSocketClient } from "./websocket/client";
import { override_config } from "./config/index.js";
import { Decompress } from "fflate";

import wasm_worker from "@finos/perspective/src/js/perspective.worker.js";
import wasm from "@finos/perspective/dist/pkg/esm/perspective.cpp.wasm";
import wasm_worker from "../../src/js/perspective.worker.js";
import wasm from "../../dist/pkg/esm/perspective.cpp.wasm";

const INLINE_WARNING = `Perspective has been compiled in "inline" mode.`;

3 changes: 1 addition & 2 deletions packages/perspective/src/js/perspective.node.js
Original file line number Diff line number Diff line change
@@ -26,8 +26,7 @@ const load_perspective =
require("../../dist/pkg/esm/perspective.cpp.js").default;

const LOCAL_PATH = path.join(process.cwd(), "node_modules");
const buffer =
require("@finos/perspective/dist/pkg/esm/perspective.cpp.wasm").default;
const buffer = require("../../dist/pkg/esm/perspective.cpp.wasm").default;

function deflate(buffer) {
let parts = [];
2 changes: 1 addition & 1 deletion packages/perspective/src/js/perspective.worker.js
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
*
*/

import load_perspective from "@finos/perspective/dist/pkg/esm/perspective.cpp.js";
import load_perspective from "../../dist/pkg/esm/perspective.cpp.js";
import perspective from "./perspective.js";

export default globalThis.perspective = perspective(load_perspective);
4 changes: 1 addition & 3 deletions rust/perspective-viewer/src/rust/lib.rs
Original file line number Diff line number Diff line change
@@ -70,9 +70,7 @@ pub fn get_exprtk_commands() -> ApiResult<Box<[JsValue]>> {
#[wasm_bindgen(js_name = "defineWebComponents")]
pub fn js_define_web_components() {
tracing_wasm::set_as_global_default();
define_web_components!(
"export * as psp from '@finos/perspective-viewer/dist/pkg/perspective.js'"
);
define_web_components!("export * as psp from '../../dist/pkg/perspective.js'");
}

/// Register Web Components with the global registry, given a Perspective
2 changes: 1 addition & 1 deletion rust/perspective-viewer/src/ts/bootstrap.ts
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
*/

import { WASM_MODULE } from "./init";
import { PerspectiveViewerElement } from "@finos/perspective-viewer/dist/pkg/perspective.js";
import { PerspectiveViewerElement } from "../../dist/pkg/perspective.js";

// This can be done automatically by enabling the `defin_web_components_async`
// feature, but due to async loading, `<perspective-viewer>` methods will not be
3 changes: 2 additions & 1 deletion rust/perspective-viewer/src/ts/extensions.ts
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@

import type { IPerspectiveViewerElement } from "./viewer";
import type { HTMLPerspectiveViewerPluginElement } from "./plugin";
import type React from "react";

// JSX / React extensions

@@ -50,7 +51,7 @@ declare global {
}
}

import { PerspectiveViewerElement } from "@finos/perspective-viewer/dist/pkg/perspective.js";
import { PerspectiveViewerElement } from "../../dist/pkg/perspective.js";

// This unused class asserts that the _real_ class (the one generated by
// `wasm-bindgen`) implements the same interface we register to the
4 changes: 2 additions & 2 deletions rust/perspective-viewer/src/ts/init.ts
Original file line number Diff line number Diff line change
@@ -9,8 +9,8 @@
*/

import { Decompress } from "fflate";
import init_wasm, * as wasm_module from "@finos/perspective-viewer/dist/pkg/perspective.js";
import wasm from "@finos/perspective-viewer/dist/pkg/perspective_bg.wasm";
import init_wasm, * as wasm_module from "../../dist/pkg/perspective.js";
import wasm from "../../dist/pkg/perspective_bg.wasm";

// There is no way to provide a default rejection handler within a promise and
// also not lock the await-er, so this module attaches a global handler to
16 changes: 15 additions & 1 deletion rust/perspective-viewer/test/js/migrate_viewer.spec.js
Original file line number Diff line number Diff line change
@@ -261,12 +261,26 @@ const TESTS = [
];

utils.with_server({}, () => {
describe(
"Viewer config migrations",
() => {
for (const [name, old, current] of TESTS) {
test(`Migrate '${name}'`, () => {
expect(convert(old, { replace_defaults: true })).toEqual(
current
);
});
}
},
{ root: path.join(__dirname, "..", "..") }
);

describe.page(
"superstore-all.html",
() => {
describe("migrate", () => {
for (const [name, old, current] of TESTS) {
test.capture(`restore '${name}'`, async (page) => {
test.skip(`restore '${name}'`, async (page) => {
const converted = convert(
JSON.parse(JSON.stringify(old))
);
2 changes: 0 additions & 2 deletions tools/perspective-bench/package.json
Original file line number Diff line number Diff line change
@@ -14,8 +14,6 @@
"url": "https://github.com/finos/perspective/packages/perspective-bench"
},
"scripts": {
"build": ":",
"clean": ":",
"bench": "node src/js/bench.js"
},
"author": "",
2 changes: 0 additions & 2 deletions tools/perspective-test/package.json
Original file line number Diff line number Diff line change
@@ -13,8 +13,6 @@
"url": "https://github.com/finos/perspective/tools/perspective-test"
},
"scripts": {
"build": ":",
"clean": ":",
"prebench": "mkdirp build",
"bench": "node bench/versions.js"
},

0 comments on commit fb6a541

Please sign in to comment.