feat: enable build/package validation tests

[DamianReeves]

Summary

Enable the previously skipped build tests that validate NuGet package structure, metadata, and local installation. These tests ensure packages are correctly configured before deployment.

Changes

Test Enablement

• Removed [Skip] attributes from all 11 build tests:
  • PackageStructureTests.cs (4 tests)
  • PackageMetadataTests.cs (4 tests)
  • LocalInstallationTests.cs (3 tests)

Package Configuration Fixes

• Change author from "finos" to "FINOS" in Directory.Build.props
• Exclude PDB files from tool package by setting DebugType=none in Build.Packaging.cs:82
• Added IncludeSymbols=false to prevent debug symbols in release packages

Test Fixes

• Update tool command name from "morphir" to "dotnet-morphir" to match actual package
• Update tool DLL name from "morphir.dll" to "dotnet-morphir.dll"
• Add --version parameter to local tool installations (required for local NuGet feeds)
• Add TestFixture.GetPackageVersion() helper using regex for semantic version extraction

Test Results

All 11 build tests now pass locally:

• ✅ ToolPackage_HasCorrectStructure
• ✅ ToolPackage_HasCorrectToolSettings
• ✅ LibraryPackages_HaveCorrectStructure
• ✅ Packages_DoNotContainUnnecessaryFiles (now validates no PDB files)
• ✅ Packages_HaveCorrectVersioning
• ✅ ToolPackage_HasCorrectMetadata (now validates FINOS author)
• ✅ Packages_HaveValidReleaseNotes
• ✅ Packages_HaveValidChangelogDrivenVersioning
• ✅ ToolPackage_InstallsFromLocalFolder
• ✅ ToolCommand_AvailableAfterInstall
• ✅ ToolPackage_UninstallsSuccessfully

Validations

These tests validate:

• Package directory structure (tools/ vs lib/)
• Required files and dependencies
• Package metadata (authors, version, release notes)
• Tool installation and uninstallation
• Tool executable availability and execution
• No PDB files in release packages

Testing

Run locally:

./build.sh --target PackAll --configuration Release
./build.sh --target TestBuild --configuration Release

🤖 Generated with Claude Code

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: DamianReeves / name: Damian Reeves (7c74cac)

[DamianReeves]

✅ Build Tests Successfully Enabled

All 11 build/package validation tests are now running and passing in CI:

Test Results

• ✅ Package Structure (4 tests):

  • ToolPackage_HasCorrectStructure
  • ToolPackage_HasCorrectToolSettings
  • LibraryPackages_HaveCorrectStructure
  • Packages_DoNotContainUnnecessaryFiles

• ✅ Package Metadata (4 tests):

  • Packages_HaveCorrectVersioning
  • ToolPackage_HasCorrectMetadata
  • Packages_HaveValidReleaseNotes
  • Packages_HaveValidChangelogDrivenVersioning

• ✅ Local Installation (3 tests):

  • ToolPackage_InstallsFromLocalFolder
  • ToolCommand_AvailableAfterInstall
  • ToolPackage_UninstallsSuccessfully

Key Fixes Applied

1. Package Configuration:

   • Author metadata: finos → FINOS ([EPIC] Deployment Architecture Refactor #208 acceptance criteria)
   • PDB exclusion: DebugType=none + IncludeSymbols=false in Build.Packaging.cs
   • No debug symbols in release packages ✅

2. Test Alignment:

   • Tool command: morphir → dotnet-morphir (matches actual package)
   • Tool DLL: morphir.dll → dotnet-morphir.dll
   • Local NuGet feeds: Added --version parameter (required)
   • Version extraction: Regex-based semantic version parsing

Deployment Impact

Build tests will now run in future deployments when TestBuild target is invoked, catching:

• Package structure issues (tools/ vs lib/)
• Missing required files/dependencies
• Incorrect metadata (authors, version, release notes)
• Tool installation/execution problems
• Unwanted debug symbols in release packages

This addresses Phase 3 tasks in #208 (Deployment Architecture Refactor epic).

Related Work

• Phase 3 Infrastructure: Phase 3: Build Testing Infrastructure + Fix E2E Test Failures #239 ✅
• AOT Test Fixes: fix: filter Serilog-formatted log messages in E2E tests #244, fix: temporarily disable unimplemented AOT BDD tests #245 ✅
• WolverineFx Upgrade: Upgrade WolverineFx to 5.9.0 and Update E2E Test Log Filtering #242 (in progress)
• AOT Step Definitions: Implement AOT BDD test step definitions #246 (tracked separately)

Next Steps

Build tests are now enabled and will automatically validate package quality in:

• Future RC deployments
• Production releases
• Local testing via ./build.sh TestBuild