Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Maven executable JAR and skip key generation for sandbox #217

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Fix Maven executable JAR and skip key generation for sandbox #217

merged 2 commits into from
Apr 3, 2023

Conversation

ystxn
Copy link
Member

@ystxn ystxn commented Feb 24, 2023

Description

Closes #215 and #216

  • Fix maven executable JAR bug
  • Skip the generation of key pair if the host supplied uses develop2.symphony.com
  • Provide an appropriate end message for the developer to use their supplied key instead
  • For non-sandbox hosts, clarify that the end message is meant for pod administrators to action

@ystxn ystxn requested a review from a team February 24, 2023 06:08
@ystxn ystxn force-pushed the feature/fix-maven branch from f0968f9 to fce60d9 Compare March 30, 2023 09:23
@ystxn ystxn merged commit f0436c2 into master Apr 3, 2023
@ystxn ystxn deleted the feature/fix-maven branch April 3, 2023 07:35
@ystxn ystxn mentioned this pull request May 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphony-soufiane symphony-soufiane symphony-soufiane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maven Spring Project generates non-executable JAR
2 participants
@ystxn @symphony-soufiane