Improve the generated project build capability #200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yinan-symphony
force-pushed
the
bugfix/local-package-manager
branch
from
3814c67 to
02b7a42
Compare
README.md
Outdated
| @@ -31,6 +31,10 @@ export https_proxy=http://localhost:3128 | |||
| ``` | |||
| Symphony Generator will automatically fetch the latest version of BDKs/WDK and use it to generate your project. In case the request fails, it will fallback on a default version. | |||
|
|
|||
| Once the project is generated, the generator will try to download the chosen package manager wrapper to build the project, if for any reason (e.g. network constraint) the build fails, the generator will then try to build project again by using local package manager. | |||
There was a problem hiding this comment.
We can improve this line IMO. Let's mention it is specific to BDK Java bots.
Suggested change
| Once the project is generated, the generator will try to download the chosen package manager wrapper to build the project, if for any reason (e.g. network constraint) the build fails, the generator will then try to build project again by using local package manager. | |
| In case of a Java bot application, once the project is generated, the generator will try to download the chosen package manager wrapper to build it. If for any reason (e.g. network constraint) the build fails, the generator will then try to build the project again by using local package manager. |
| this.spawnCommandSync('gradle', ['build']); | ||
| } catch(e) { | ||
| this.log(`${e}`.green.bold); | ||
| console.log(errorMessage); |
There was a problem hiding this comment.
Is it done on purpose to not show the actual error? only "Failed to build the generated project?".
How can users figure out why the generation failed?
There was a problem hiding this comment.
the actual error is shown by the line 209. The error message is a generic message.
and as i mentioned this morning, the real error message will display by all means.
yinan-symphony
force-pushed
the
bugfix/local-package-manager
branch
from
02b7a42 to
ddfb10d
Compare
Before this commit, the generation process would stop in case the build on the generated project fails. For instance, the package manager wrapper cannot be downloaded due to network issue. This commit improves the project build capability by tring to run a the build again by using a local package manager in case there is an issue when build fails using wrapper. In addition, no matter what the build status is, the generation process will continue to the end.
yinan-symphony
force-pushed
the
bugfix/local-package-manager
branch
from
ddfb10d to
6d27087
Compare
symphony-soufiane
approved these changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the generation process would stop in case the build
on the generated project fails. For instance, the package manager wrapper
cannot be downloaded due to network issue.
This commit improves the project build capability by tring to run
a the build again by using a local package manager in case there is an
issue when build fails using wrapper. In addition, no matter what the build
status is, the generation process will continue to the end.
Description
Closes #199