Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting privateChannelAddEventListenerRequest to include null as a valid listenerType #1446

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kriswest
Copy link
Contributor

Describe your change

The DesktopAgent API allows null as the type argument for PrivateChannel.addEventListener but the privateChannelAddEventListenerRequest message schema intended to support that API call does not and needs to be corrected.

Related Issue

resolves #1445

Contributor License Agreement

  • I acknowledge that a contributor license agreement is required and that I have one in place or will seek to put one in place ASAP.

Review Checklist

  • Issue: If a change was made to the FDC3 Standard, was an issue linked above?
  • N/A CHANGELOG: Is a CHANGELOG.md entry included?
  • API changes: Does this PR include changes to any of the FDC3 APIs (DesktopAgent, Channel, PrivateChannel, Listener, Bridging)?
    • Docs & Sources: If yes, were both documentation (/docs) and sources updated?

      JSDoc comments on interfaces and types should be matched to the main documentation in /docs
    • Conformance tests: If yes, are conformance test definitions (/toolbox/fdc3-conformance) still correct and complete?

      Conformance test definitions should cover all required aspects of an FDC3 Desktop Agent implementation, which are usually marked with a MUST keyword, and optional features (SHOULD or MAY) where the format of those features is defined
    • Schemas: If yes, were changes applied to the Bridging and FDC3 for Web protocol schemas?

      The Web Connection protocol and Desktop Agent Communication Protocol schemas must be able to support all necessary aspects of the Desktop Agent API, while Bridging must support those aspects necessary for Desktop Agents to communicate with each other
      • If yes, was code generation (npm run build) run and the results checked in?

        Generated code will be found at /src/api/BrowserTypes.ts and/or /src/bridging/BridgingTypes.ts
  • Context types: Were new Context type schemas created or modified in this PR?
    • Were the field type conventions adhered to?
    • Was the BaseContext schema applied via allOf (as it is in existing types)?
    • Was a title and description provided for all properties defined in the schema?
    • Was at least one example provided?
    • Was code generation (npm run build) run and the results checked in?

      Generated code will be found at /src/context/ContextTypes.ts
  • Intents: Were new Intents created in this PR?

@kriswest kriswest requested a review from a team as a code owner November 25, 2024 15:05
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for fdc3 ready!

Name Link
🔨 Latest commit a30f96e
🔍 Latest deploy log https://app.netlify.com/sites/fdc3/deploys/6744922435542e000810d30a
😎 Deploy Preview https://deploy-preview-1446--fdc3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kemerava
Copy link
Contributor

@kriswest does this need a CHANGELOG?

@kriswest
Copy link
Contributor Author

@kemerava I did ponder that. I think that as its an unreleased version thats being corrected for an unintended error, no. But opinions may vary on that.

Copy link
Contributor

@kemerava kemerava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kriswest kriswest requested a review from a team December 2, 2024 14:17
@kriswest
Copy link
Contributor Author

kriswest commented Dec 5, 2024

Approved at SWG #1458

@kriswest kriswest merged commit d5aab3f into main Dec 11, 2024
10 checks passed
@kriswest kriswest deleted the fdc3-for-web-fix-private-channel-events branch December 11, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FDC3 for Web: PrivateChannel event listeners should support null type (all events)
3 participants