Add missing argument in bridging message for findIntentByContext #1212
Conversation
✅ Deploy Preview for fdc3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -5280,6 +5282,7 @@ const typeMap: any = { | |||
| ], false), | |||
| "FindIntentsByContextAgentRequestPayload": o([ | |||
| { json: "context", js: "context", typ: r("ContextElement") }, | |||
| { json: "resultType", js: "resultType", typ: u(undefined, "") }, | |||
There was a problem hiding this comment.
Just for my own understanding, I was wondering if typ: u(undefined, "") violates the 'no unions of primitive types' guidelines from this PR #1200 , but I assume this is how optional parameters are expressed here, and this is fine because it's really just an optional string.
There was a problem hiding this comment.
I know its fine in this case as we already have optional parameters elsewhere and those can generally be implemented via alternative function signatures in other languages. I'd probably also exclude null from the set of primitive types when considering this as most languages have someway of supporting that (e.g. Nullable<int> i = null; in C#, or using the Integer class in Java instead of int.
|
This PR when in without a changelog entry, which we will need to add before the next version of FDC3 is adopted |
resolves #1211