Skip to content

feat: update ios and android agents to v2.7.0 INTER-1002 #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 47 commits into from
Jan 9, 2025
Merged

feat: update ios and android agents to v2.7.0 INTER-1002 #135

merged 47 commits into from
Jan 9, 2025

Conversation

Orkuncakilkaya
Copy link
Contributor

@Orkuncakilkaya Orkuncakilkaya commented Nov 19, 2024 •
edited
Loading

This PR solves INTER-1002

ilfa
ilfa reviewed Nov 19, 2024
View reviewed changes
@Orkuncakilkaya Orkuncakilkaya marked this pull request as ready for review December 3, 2024 09:11
@Orkuncakilkaya Orkuncakilkaya marked this pull request as draft December 3, 2024 10:56
@necipallef necipallef changed the title feat: update ios and android agents to v2.7.0 feat: update ios and android agents to v2.7.0 INTER-1002 Dec 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

Coverage report

St.❔
 Category Percentage Covered / Total
🔴 Statements
47.14% (+4.74% 🔼)
 66/140
🔴 Branches
38.78% (+14.45% 🔼)
 19/49
🔴 Functions
43.9% (+1.4% 🔼)
 18/41
🔴 Lines
45.59% (+5.09% 🔼)
 62/136
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🔴 errors.ts
15.38% (-0.62% 🔻)
10.71% (-0.4% 🔻)
15.38% (-0.62% 🔻)
15.38% (-0.62% 🔻)

Test suite run success

21 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 538808f

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🔴 All files 47.14 38.77 43.9 45.58
🟡  FingerprintJsProAgent.ts 76.92 76.47 100 76.92 39,59-62,95,103
🟡  FingerprintJsProContext.ts 75 100 0 75 5
🟢  FingerprintJsProProvider.tsx 93.33 50 100 93.33 44
🔴  errors.ts 15.38 10.71 15.38 15.38 8-33,56-249,272-285,332-336,343-379,383
🔴  index.ts 0 0 0 0
🔴  types.ts 0 0 0 0
🟢  useVisitorData.ts 100 100 100 100

ilfa
ilfa reviewed Dec 16, 2024
View reviewed changes
ilfa
ilfa reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@ilfa ilfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the markup to improve the UX of the demo project on the small screens. Also, I added 2 tests to be sure about timeout behavior.

In general I found only one problem - an outdated lock file for TestProject.

@necipallef necipallef marked this pull request as ready for review December 24, 2024 08:59
necipallef
necipallef previously approved these changes Dec 24, 2024
View reviewed changes
ilfa
ilfa reviewed Jan 7, 2025
View reviewed changes
@necipallef necipallef force-pushed the update-agents-to-2-7-0 branch 3 times, most recently from 54baaf0 to 144dd4c Compare January 7, 2025 16:51
necipallef and others added 21 commits January 7, 2025 19:55
@necipallef
chore: undo pre-commit hook deletion
f71ca40
@necipallef
chore: undo pre-commit hook deletion
6c9e0d4
@necipallef
test: attempt to fix jest in TestProject
06032ed
@necipallef
test: attempt to fix jest in TestProject
34f2826
@necipallef
chore: fix getData type missing requestOptions
59ffcc5
@necipallef
test: add unit tests for timeout functions
e1847a2
@necipallef
test: attempt to fix jest in TestProject
fb6ac01
@necipallef
test: fix getVisitorDataWithTimeout test
1bbbf12
@necipallef
test: temprorarily disable running jest for TestApp
2704b0b
@necipallef
chore: jsdoc for options param
14dd15e
@necipallef
chore: correct native function call when timeout is 0
28862b0
@necipallef
test: add different test cases for the TestProject
74d2661
@ilfa @necipallef
chore: fix markup in test project for small screens
7f34b73
@ilfa @necipallef
test: add 2 more testcases for timeout to be sure
adb0838
@necipallef
chore: test project lock file
f57484e
@necipallef
test: improve test description
0bc6f18
@necipallef
docs(readme): include new gradle dependency management structure inst…
211b695 
…allation method
@JuroUhlar @necipallef
chore: polish readme
7572f21
@JuroUhlar @necipallef
chore: simplfiy extended response format
e727244
@necipallef
docs(readme): remove jitpack completely
e200e81
@necipallef
docs(readme): fix code snippet
538808f
@necipallef necipallef force-pushed the update-agents-to-2-7-0 branch from 144dd4c to 538808f Compare January 7, 2025 16:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

This PR will create a minor release 🚀

3.3.0 (2025-01-07)

Features

  • add custom timeout feature (02757ef)
  • add sealed result support (37dbe7f)
  • update iOS and Android SDKs to v2.7.0 (eafa1d4)

@ilfa ilfa merged commit b98f75c into main Jan 9, 2025
8 checks passed
@ilfa ilfa deleted the update-agents-to-2-7-0 branch January 9, 2025 17:50
@fingerprint-dx-team
Copy link

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necipallef necipallef necipallef left review comments

@ilfa ilfa ilfa approved these changes

@mgutski mgutski mgutski approved these changes

@Alexey-Verkhovsky Alexey-Verkhovsky Alexey-Verkhovsky approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Orkuncakilkaya @ilfa @mgutski @necipallef @Alexey-Verkhovsky @JuroUhlar