Fix empty Genres tab - #1670
Merged
Chaphasilor merged 2 commits intoJul 2, 2026
Merged
Conversation
The Genres tab was the only music-screen tab that passes an isFavorite query param. getIsFavoriteFilter returned `false` (not null) when no favorite filter was active, so finamp sent `/Genres?...&isFavorite=false`. Jellyfin 10.10/10.11 return HTTP 500 for /Genres on any isFavorite value, which left the tab empty (offline was unaffected since it never hits /Genres). Return null when the favorite filter is inactive so the param is omitted.
This comment was marked as outdated.
This comment was marked as outdated.
Member
|
Whoops sorry, I got a bit confused about which branch and test server I was on 😅 So what I found is:
Your fix indeed works for all three versions, so thanks! It's what I would've done too, so props to Claude I guess ^^ |
kontell
force-pushed
the
fix/genres-isfavorite-500
branch
from
July 2, 2026 09:42
176c937 to
29efa37
Compare
Author
|
Claude's been nixed now, thanks for reviewing this. |
Member
|
Awesome, thanks for whipping this up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Genres tab is empty when online. Other tabs work and offline mode lists genres fine.
I had Claude (Opus 4.8) debug the issue and it came up with the below.
Cause
getIsFavoriteFilterreturnsfalse(instead ofnull) for the genres/mixed tabs when no favorite filter is active, so finamp sendsisFavorite=falseto the/Genresendpoint. Jellyfin 10.10/10.11 returns HTTP 500 on/GenreswheneverisFavoriteis present (trueorfalse), so the request fails and the tab stays empty./Items(used by the other tabs) acceptsisFavorite=false, and offline never calls/Genres— which is why only the online Genres tab breaks.Fix
Return
nullwhen the favorite filter is inactive, soisFavoriteis omitted from the/Genresrequest.Verification (Jellyfin 10.11.11)
/Genres?…&isFavorite=false→ 500/Genres?…(noisFavorite) → 200/Items?…&isFavorite=false→ 200Out of scope
Filtering the Genres tab by favorites still won't work on 10.11 (that path sends
isFavorite=true, which also 500s). That looks like a server-side bug in Jellyfin's/Genresendpoint and may be worth reporting upstream separately.Fixes #1653