Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed swappable final-form APIs #520

Merged
merged 1 commit into from
Jun 11, 2019
Merged

Allowed swappable final-form APIs #520

merged 1 commit into from
Jun 11, 2019

Conversation

erikras
Copy link
Member

@erikras erikras commented Jun 11, 2019

Suggested in a tweet

@erikras do you have any interest in allowing the React bindings for @finalformjs to receive the FormApi instance as a prop? I'm interested in it for testing purposes but I could imagine it also having value if someone wanted to pass a custom FF compatible API impl.

It took me a minute to understand what was being asked, but when I did, it seemed like a pretty cool idea. Just as Final Form doesn't mind what view framework consumes it, React Final Form shouldn't mind what underlying engine that comports to the Final Form API is being used.

@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #520 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #520   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          16     16           
  Lines         232    232           
  Branches       56     57    +1     
=====================================
  Hits          232    232
Impacted Files Coverage Δ
src/ReactFinalForm.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fe62c5...dc235ec. Read the comment docs.

@erikras erikras merged commit c3912b0 into master Jun 11, 2019
@erikras erikras deleted the alternate-form-api branch June 11, 2019 08:04
@erikras
Copy link
Member Author

erikras commented Jun 11, 2019

Published in v6.1.0.

@lock
Copy link

lock bot commented Jul 11, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant