Modified to handle errors during read path #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velvia
reviewed
Mar 21, 2017
| @@ -20,6 +20,7 @@ object Util { | |||
| if (resultSet.wasApplied) Success else notAppliedResponse | |||
| }.recover { | |||
| case e: DriverException => throw StorageEngineException(e) | |||
| case e: Exception => throw e | |||
There was a problem hiding this comment.
I think we should still wrap the error in StorageEngineException.
| @@ -30,6 +31,7 @@ object Util { | |||
| // from invalid Enum strings, which should never happen, or some other parsing error | |||
| case e: NoSuchElementException => throw MetadataException(e) | |||
| case e: IllegalArgumentException => throw MetadataException(e) | |||
| case e: Exception => throw e | |||
There was a problem hiding this comment.
Same here, wrap in StorageEngineException
|
Added this general exception to handle just in case of other errors than DriverException. But this is not the code actually solving the issue. The changes made to the ChunkRowMap table helped to throw exception back to the client. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: No error is displayed when cassandra nodes are down for read path #120