Use git_repository instead of http_archive for bazel-bats download #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to peg to a commit ID anyways, and this way you can simply set the commit ID without needing an explicit release. Since we don't really package anything except for source files, there is no advantage to downloading an archive instead. It is a bit more labor intensive to clone a git repo, but this is a small repo so it shouldn't be an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to peg to a commit ID anyways, and this way you can simply set the commit ID without needing an explicit release.
Since we don't really package anything except for source files, there is no advantage to downloading an archive instead. It is a bit more labor intensive to clone a git repo, but this is a small repo so it shouldn't be an issue.