-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PWAs just open a new firefox window #395
Comments
I have the same issue. Used to work with youtube music fine. Now its just a new firefox window. |
This is probably duplicate of #388, You can run "Update web apps" from the extension settings to apply the fix. |
Did not mean to close, sorry, I am not used to GitHub's UI. |
Does it work if you install a new web app into a new profile? Also, please follow these steps to obtain native and runtime logs and provide them here. |
I have the exact same problem: A regular, vanilla-looking Firefox window opens with a new tab every time I try to open a web app. After some testing, this bug seems to occur after choosing "Reinstall runtime" in the extension settings. (Maybe this has to do with originally using the .msi file to install PWAsForFirefox? It seems like the profiles are corrupted, idk.) A fix/workaround that works for me is to create a new profile, and use that for web apps instead of the default one. After "removing" the Default profile (which apparently only clears its web apps and data), web apps installed through the Default profile now open a window with PWAsForFirefox's custom layout... but the entire page is blank, labelled "New Tab", and I cannot access any pages, including the settings. Neither reinstalling the extension, nor reinstalling manually with the .msi file, nor choosing "Update Web Apps" fixes this problem. I've attached a runtime log of the Default profile before I "removed" it. I have not been able to open developer tools in it after clearing it. |
Same problem here, creating new profiles does not help in my case |
Please try to launch your web app from console with:
You can get the site ID with:
This should display runtime logs, regardless if startup is broken. You can try to remove |
|
Can you send the content of |
Can confirm I had this after updating, choosing update web apps did not fix it, using a new profile did. To avoid losing my data though, I managed to fix it with always patch runtime and profile enabled - this fixed it and all apps remained fixed even after disabling this option. |
Yeah, this makes sense. I thought "Update all web apps" will also re-patch the runtime, but it doesn't. So, if anyone else has this problem, try enabling "Always patch runtime and profile" and launch web apps. You can later disable it. I still don't know why runtime isn't automatically patched when needed for some users, but that is probably #165. |
Yeah, that makes sense - so question is, what does always patch runtime and profile do that update all web apps doesn't? |
It always calls |
Perhaps the update all web apps feature should also call these then? |
Maybe, but it's not really updating web apps. A separate "Patch all profiles (and runtime)" button might be better. Also, in the next major release (which I don't know yet when will happen), I will probably rewrite how loading works so pitching won't be needed anymore. But I'm not sure yet. |
I'll close this issue. If you still have problems after trying this solution, please let me know. I'll probably also add "Patch all profiles (and runtime)" button in the next release. |
Yeah, it's still not working for me. |
Please send the content of Also, can you go to the extension settings and to about this project, and copy all version information? |
Hello. I have a similar issue, except it just opens the PWA twice (or more) no matter how many times I click on the icon. I have several PWAs and they're all fine. When I click on their icon they switch to their window if they're already open. However, with a PWA I made for deck.blue, everytime I click on the app in my dock, it doesn't switch to it, but launches a new window. A new PWA window though, not a new firefox window. What can I provide to help diagnose the issue? |
So, this happens only with one specific PWA, while others are fine? Well, the first thing you can do to diagnose this is to check if "When launching a web app that is already opened" is set to "Focus the existing window" in the settings. You may also need to restart PWAs to apply the setting. If that is set correctly but doesn't work, I'll check if there are any other things you can diagnose. |
Well, nevermind. There must have been an update somehow or maybe I restarted my system and it fixed it, but the issue isn't there anymore. Sorry for the trouble :) |
Description
Whenever I open a PWA that I've made, it just opens a new, normal firefox window.
Steps to Reproduce
Additional Information
Affected Websites
Environment
The text was updated successfully, but these errors were encountered: