Implement base64_attachments #12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message.parse() takes `signal: SignalAPI` instance as parameter, which allows us to call its new get_attachment() method. As a result, the Message.parse() needs to be `async` now.
for cases where `base64_attachments` parameter is not `None`
Owner
|
Awesome, thank you very much! I will take a closer look the coming days. I have to fix the deployment pipeline first and also tidy up a few things, but then I can test and merge it |
Merged
Collaborator
|
Closing this as it is superseeded by #67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi filipre!
This is my first approach at implementing base64_attachments. Although the changes are pretty straightforward, I don't think this is the most elegant way to do it. However, I'm also unable to come up with better alternatives. So I thought I'd just use this PR to maybe get a discussion going and see where we go from there.
Kind regards from another part of Germany
Felix