Remove handlers

Author: filipopo

handlers/systemctl.yml

@@ -51,6 +51,3 @@
         - mobileforces-masterserver
         - mobileforces
         - mobileforces-fastdl
-
-  handlers:
-    - ansible.builtin.import_tasks: handlers/systemctl.yml

playbook.yml

@@ -16,6 +16,7 @@
     src: templates/webserver/vhosts/mobileforces.j2
     dest: /etc/apache2/sites-available/mobileforces.conf
     mode: "644"
+  register: apache_vhost
 
 - name: Copy website files
   ansible.builtin.copy:
@@ -56,6 +57,12 @@
     cmd: "certbot --apache -n --email {{ ServerAdmin }} --agree-tos --no-redirect -d {{ ServerName }}"
     creates: /etc/apache2/sites-enabled/mobileforces-le-ssl.conf
 
+- name: Reload apache
+  ansible.builtin.service:
+    name: apache2
+    state: reloaded
+  when: apache_vhost.changed
+
 - name: PHP tasks (skipped in check mode)
   block:
     - name: Get PHP version
@@ -70,14 +77,13 @@
       loop:
         - [= www-data, "= {{ server_user }}"]
         - ["/run/php/php{{ php.stdout }}-fpm.sock", /run/php/www.sock]
+      register: fpm_config
 
-    - name: Reload the apache and PHP fpm services
+    - name: Reload the PHP fpm service
       ansible.builtin.service:
-        name: "{{ item }}"
+        name: "php{{ php.stdout }}-fpm"
         state: reloaded
-      loop:
-        - apache2
-        - "php{{ php.stdout }}-fpm"
+      when: fpm_config.changed
   when: not ansible_check_mode
 
 - name: Allow the website to restart game services

tasks/create_apache_webserver.yml

@@ -63,7 +63,11 @@
     - [mobileforces.j2, mobileforces.service]
     - [mobileforces-fastdl.j2, mobileforces-fastdl.service]
     - [mobileforces-package.j2, mobileforces-package.service]
-  notify: Reload systemctl
+  register: service_files
+
+- name: Reload systemctl
+  ansible.builtin.command: systemctl daemon-reload
+  when: service_files.changed
 
 - name: Create cron job for fastdl
   ansible.builtin.cron:

tasks/create_mf_gameserver.yml

@@ -31,4 +31,8 @@
     src: templates/masterserver/services/mobileforces-masterserver.j2
     dest: /etc/systemd/system/mobileforces-masterserver.service
     mode: "644"
-  notify: Reload systemctl
+  register: service_files
+
+- name: Reload systemctl
+  ansible.builtin.command: systemctl daemon-reload
+  when: service_files.changed