Add support to static binaries (windows/linux amd64) #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I still see the |
|
It's fair enough. I'm going to change this. Thanks for reviewing. |
|
It's done @jsixface. I'm going to create a new pull request removing the remotes support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a long winter, this pull request provides support to build a static binary for windows and linux on every pull request. They might be easily downloaded in the github actions artifacts section and be used directly without any previous configuration.
To achive this, I'm removing a minor feature (support to remotes tables), and because of that, the intent is to release this as a v2.0.0.
Next steps is to create acceptance tests using the binaries to make sure that gitql returns always the same values for specific queries.