Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'like' functionality in where clause #64

Merged
merged 3 commits into from
Jan 14, 2018

Conversation

jsixface
Copy link
Contributor

Fixes may be first part of #59

gitql 'select message, author from commits where message like "%author%"'
+--------------------------------+----------+
|            message             |  author  |
+--------------------------------+----------+
| support for full_message,      | cloudson |
| message, author, committer     |          |
+--------------------------------+----------+

@luizperes
Copy link
Collaborator

Hey @jsixface, I will check this one later as it has some file conflicts, ok?

@jsixface
Copy link
Contributor Author

jsixface commented Nov 1, 2017

@luizperes The conflicts are due to the previous pull requests.
The changes on that pull request and this one overlap. I'll fix them

@luizperes
Copy link
Collaborator

Thank you @jsixface, sorry, I haven't had the time to check your PR. Will try to do it over the weekend! :)

@jsixface
Copy link
Contributor Author

jsixface commented Nov 3, 2017

@luizperes Sure. No hurry.

@luizperes
Copy link
Collaborator

Hi @cloudson, what do you think about that? :)

@filhodanuvem
Copy link
Owner

It looks good for me, but I'm not sure about run like statement using escaped %.
Anyway, I'm going to test it manually.

Thanks @jsixface

@luizperes
Copy link
Collaborator

Sounds good @cloudson, please update us back :) thanks!

@filhodanuvem
Copy link
Owner

Here I am. The Code is good for me @jsixface .
Sorry for the delay to check it.
I've tried to create a test with the literal % char and its failed but we can in another PR work on it.

@filhodanuvem filhodanuvem merged commit 6716a7a into filhodanuvem:develop Jan 14, 2018
@jsixface jsixface deleted the feature/WhereClauseLike branch October 19, 2018 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants