Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add not equals validation #62

Merged
merged 3 commits into from
Nov 1, 2017

Conversation

jsixface
Copy link
Contributor

Add Not equals validation to the where clause.

gitql "select committer from commits where committer != 'Arumugam J' order by date desc limit 1"
+-----------+
| committer |
+-----------+
| GitHub    |
+-----------+

It was originally not validating the where clause if it has a != sign. Fixes #58

@luizperes
Copy link
Collaborator

Hi @jsixface, is there any problem with the operator <> ? I am asking that because this is the actual lexeme for not equals in SQL, right? Thanks! :)

@jsixface
Copy link
Contributor Author

In my SQL experience, I've never used <> for not equal to. Is that the proper usage?

@luizperes
Copy link
Collaborator

what do you think of supporting both? (as per https://stackoverflow.com/questions/723195/should-i-use-or-for-not-equal-in-t-sql)

@jsixface
Copy link
Contributor Author

yeah. I'll add support for <> as well.

@jsixface jsixface force-pushed the feature/WhereNotEquals branch from 46494bc to 21e7a8a Compare October 30, 2017 02:13
@jsixface
Copy link
Contributor Author

jsixface commented Nov 1, 2017

@luizperes Added the operator <> for not equal to.

@luizperes
Copy link
Collaborator

Sounds good @jsixface! Thanks for your contributions and sorry for the delay in reviewing it. :)

@luizperes luizperes merged commit fa64865 into filhodanuvem:develop Nov 1, 2017
@jsixface jsixface deleted the feature/WhereNotEquals branch November 1, 2017 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants