Skip to content

Conversation

@xwnb
Copy link
Contributor

@xwnb xwnb commented Jun 25, 2025

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

Behaviors:

Screen.Recording.2025-06-25.215007.mp4

@xwnb
Copy link
Contributor Author

xwnb commented Jun 25, 2025

Two tasks need owner helps:

  1. Need a new icon for such option
  2. The string resources are automatically generated by Resx manager of VS which causes many differences. Is there a way to clean them up?

@yaira2
Copy link
Member

yaira2 commented Jun 25, 2025

The string resources are automatically generated by Resx manager of VS which causes many differences. Is there a way to clean them up?

I usually edit the en-us file manually which avoids this issue, but with Resx manager, you can revert the changes to the files before pushing the commit.

@xwnb
Copy link
Contributor Author

xwnb commented Jun 25, 2025

The string resources are automatically generated by Resx manager of VS which causes many differences. Is there a way to clean them up?

I usually edit the en-us file manually which avoids this issue, but with Resx manager, you can revert the changes to the files before pushing the commit.

Yes, I only edited the en-us actually, but the resx mgr formated and updated others. So annoyed.

@0x5bfa
Copy link
Member

0x5bfa commented Jun 25, 2025

Don't use Resource Manager, our resource files aren't optimized for it, please edit the en-US/Resources.resx in Notepad (they are optimized for Crowdin, a community translation SaaS). You can revert other files changed from the main branch, or reset the commit to revert locally on the PR branch in GitHub Desktop.

@xwnb
Copy link
Contributor Author

xwnb commented Jun 26, 2025

Don't use Resource Manager, our resource files aren't optimized for it, please edit the en-US/Resources.resx in Notepad (they are optimized for Crowdin, a community translation SaaS). You can revert other files changed from the main branch, or reset the commit to revert locally on the PR branch in GitHub Desktop.

Then how to update other language resource files?

@xwnb xwnb force-pushed the feature/hide-statusbar branch from 0ce3769 to 5880899 Compare June 26, 2025 10:55
@0x5bfa
Copy link
Member

0x5bfa commented Jun 27, 2025

Then how to update other language resource files?

Add a new data element like this. This is what I do.
Anyway, you did it well.
image

@files-community-bot
Copy link
Contributor

✅ Successfully formatted XAML files.

@mdtauk
Copy link
Contributor

mdtauk commented Jun 27, 2025

Are we implementing this without any of the additional work to handle Git repo folders? @yaira2

@yaira2
Copy link
Member

yaira2 commented Jun 27, 2025

Reposting from #17208

@xwnb the implementation in your PR is exactly how this would be done if we decide to move forward with this option. That said, we haven't made a final decision about this feature. We are pretty selective about adding new settings, and would like to see more interest before making a decision 🙂

@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 42c8207 to 4c7493f Compare July 6, 2025 15:16
@yaira2 yaira2 force-pushed the main branch 2 times, most recently from 97999e5 to 806f922 Compare September 9, 2025 21:12
@yaira2 yaira2 force-pushed the feature/hide-statusbar branch from 28bdedb to c08053d Compare November 4, 2025 14:58
@yaira2 yaira2 added the ready for review Pull requests that are ready for review label Nov 4, 2025
@yaira2 yaira2 changed the title Feature: Option to hide the bottom status bar Feature: Add an option to hide the status bar Nov 4, 2025
@yaira2 yaira2 changed the title Feature: Add an option to hide the status bar Feature: Added an option to hide the status bar Nov 4, 2025
@yaira2 yaira2 self-requested a review November 4, 2025 15:23
Signed-off-by: Yair <[email protected]>
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed ready for review Pull requests that are ready for review labels Nov 4, 2025
@yaira2
Copy link
Member

yaira2 commented Nov 4, 2025

@xwnb thank you for your PR. We're ready to move forward with this feature and will include it in the next release.

@yaira2 yaira2 merged commit 0bccda1 into files-community:main Nov 4, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge Pull requests that are approved and ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Option to hide the bottom status bar

4 participants