Code Quality: Replaced BoolToVisibilityConverter with implicit conversion expression
#16723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lamparter
force-pushed
the
builtin-converters
branch
from
6f9ca89 to
64f6fd8
Compare
Signed-off-by: Lamparter <[email protected]>
yaira2
added
the
ready to merge
|
This appears to be causing some crashes in the grid view layouts. |
|
That's not good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved / Related Issues
Steps used to test these changes
WinUI now allows you to directly apply a boolean value to a UIElement's visibility attribute.
I've gone ahead and replaced the WCT converter with an implicit conversion to make it easier to switch to 8.x down the line and relying less on WCT.