Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added support for dragging recent files #16716

Merged
merged 6 commits into from
Jan 21, 2025
Merged

Feature: Added support for dragging recent files #16716

merged 6 commits into from
Jan 21, 2025

Conversation

Lamparter
Copy link
Contributor

Resolved / Related Issues

Steps used to test these changes

  1. Opened Files
  2. Navigated to recents list
  3. Tried dragging into other areas such as desktop/browser

By default, the file is moved to the target location, over being copied or linked.

@yaira2
Copy link
Member

yaira2 commented Jan 19, 2025 •
edited
Loading

This looks like the same as #15555. Are the issues mentioned there resolved?

@Lamparter
Copy link
Contributor Author

This looks like the same as #15555. Are the issues mentioned there resolved?

Yes!

@Lamparter Lamparter requested a review from yaira2 January 19, 2025 09:58
@Lamparter @yaira2
Reword comment
49d6e9d 
Co-authored-by: Yair <[email protected]>
Signed-off-by: Lamparter <[email protected]>
yaira2
yaira2 previously approved these changes Jan 19, 2025
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 19, 2025
@yaira2
Copy link
Member

yaira2 commented Jan 19, 2025

Fyi @Krytan

@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed ready to merge Pull requests that are approved and ready to merge labels Jan 20, 2025
@Lamparter Lamparter requested a review from yaira2 January 20, 2025 07:55
@yaira2 yaira2 requested a review from d2dyno1 January 20, 2025 15:37
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed changes requested Changes are needed for this pull request labels Jan 20, 2025
d2dyno1
d2dyno1 suggested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure this will work for non-standard storage items, like .lnk files and whatnot?
In such case the Shelf's code could be used to set the DataPackage.

Also, considering that it is a duplicated version of FileList_DragItemsStarting, maybe it'd be a good opportunity to introduce a helper class

@Lamparter

d2dyno1
d2dyno1 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@d2dyno1 d2dyno1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding

@yaira2 yaira2 merged commit 5dd7a6b into files-community:main Jan 21, 2025
6 checks passed
@Lamparter Lamparter deleted the drag-recents branch January 21, 2025 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d2dyno1 d2dyno1 d2dyno1 approved these changes

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add support for dragging recent files
3 participants
@Lamparter @yaira2 @d2dyno1