Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed issue where existing tabs were duplicated when opening a folder from the outside of Files #15146

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

hishitetsu
Copy link
Member

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Bug: Opening Files from explorer.exe causes tabs to duplicate #15107

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?

@gumbarros
Copy link
Contributor

The AppInstances.Count == 0 if makes sense, thank you very much for the fix btw. But why is the LastSessionTabList no longer stored?

@hishitetsu
Copy link
Member Author

hishitetsu commented Apr 10, 2024

But why is the LastSessionTabList no longer stored?

It is no longer needed when #14795 has been merged.

@yaira2 yaira2 merged commit ea73284 into files-community:main Apr 10, 2024
6 checks passed
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Apr 10, 2024
@yaira2 yaira2 changed the title Fix: Fixed issue where open tabs were duplicated when opening a folder from the outside of Files Fix: Fixed issue where existing tabs were duplicated when opening a folder from the outside of Files Apr 10, 2024
@hishitetsu hishitetsu deleted the FixTabDuplicate branch April 10, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Opening Files from explorer.exe causes tabs to duplicate
3 participants