Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Auto update feature of FilesLauncher #11750

Merged
merged 2 commits into from
Mar 17, 2023
Merged

Feature: Auto update feature of FilesLauncher #11750

merged 2 commits into from
Mar 17, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Mar 17, 2023 •
edited
Loading

Resolved / Related Issues

  • Were these changes approved in an issue or discussion with the project maintainers? In order to prevent extra work, feature requests and changes to the codebase must be approved before the pull request will be reviewed. This prevents extra work for the contributors and maintainers.
    Closes Feature: Keep FilesLauncher.exe up to date on users devices #11746

Validation
How did you test these changes?

  • Did you build the app and test your changes?
  • Did you check for accessibility? You can use Accessibility Insights for this.
  • Did you remove any strings from the en-us resource file?
    • Did you search the solution to see if the string is still being used?
  • Did you implement any design changes to an existing feature?
    • Was this change approved?
  • Are there any other steps that were used to validate these changes?
    You can try this feature by editing or deleting FilesLaucher.exe.sha256 in the LocalAppData folder.
    A log is output when updated.

Details

  • The update process runs when the app is launched with the default file manager setting turned on.
  • This feature checks the file stored the SHA256 hash value of FilesLauncher.exe, rather than FilesLauncher.exe itself.
  • FilesLaucher.exe.sha256 is generated during the build process of FilesLauncher.

yaira2
yaira2 approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 merged commit fa2664a into files-community:main Mar 17, 2023
@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Mar 17, 2023
@hishitetsu hishitetsu deleted the AutoUpdateLauncher branch March 17, 2023 15:20
hishitetsu added a commit to hishitetsu/Files that referenced this pull request Mar 18, 2023
@hishitetsu @ferrariofilippo
@yaira2 @cinqmilleans
Resolve path (#17)
981da95 
* Fixed: Selection isn't cleared when switching between panes (files-community#11745)

* New Crowdin updates (files-community#11747)

* Feature: Improved commands for Pin/Unpin (files-community#11729)

* Feature: RichCommands Cut/Copy (files-community#11752)

* Fix PageContext (files-community#11751)

* Feature: Auto update feature of FilesLauncher (files-community#11750)

* Fix: Fixed issue with resolving paths containing dots

---------

Co-authored-by: Filippo Ferrario <[email protected]>
Co-authored-by: Yair <[email protected]>
Co-authored-by: cinqmilleans <[email protected]>
Co-authored-by: Filippo Ferrario <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Keep FilesLauncher.exe up to date on users devices
2 participants
@hishitetsu @yaira2