Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed issue where compatibility settings weren't working #11348

Merged
merged 3 commits into from
Feb 17, 2023
Merged

Fix: Fixed issue where compatibility settings weren't working #11348

merged 3 commits into from
Feb 17, 2023

Conversation

ferrariofilippo
Copy link
Contributor

@ferrariofilippo ferrariofilippo commented Feb 17, 2023 •
edited
Loading

Resolved / Related Issues
Items resolved / related issues by this PR.

Notes

  • CompatibilityOptions.FromString(options) will always return an object even when options is null
  • Since CompatibilityOptions will always have a value, the user will be able to interact with the Compatibility tab
  • Changes are saved correctly

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

yaira2
yaira2 approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added the ready to merge Pull requests that are approved and ready to merge label Feb 17, 2023
@yaira2 yaira2 changed the title Fix: Fixed Compatibility settings not working Fix: Fixed issue where compatibility settings weren't working Feb 17, 2023
@yaira2 yaira2 merged commit b137fab into files-community:main Feb 17, 2023
@ferrariofilippo ferrariofilippo deleted the Compatibility_Settings branch February 17, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Can't select any option in the "Compatibility" tab in the Properties of a .exe file.
2 participants
@ferrariofilippo @yaira2