Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixed wrong date format when language is set to Default #11087

Merged
merged 5 commits into from
Feb 1, 2023

Conversation

hishitetsu
Copy link
Member

@hishitetsu hishitetsu commented Jan 26, 2023

Resolved / Related Issues
Items resolved / related issues by this PR.

Details
ApplicationLanguages.PrimaryLanguageOverride is empty when language is set to Windows Default, so we shuold use ApplicationLanguages.Languages property instead.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots
Before:
image

After:
image

@yaira2 yaira2 changed the title Fix: Fix wrong date format when language is set to Default. Fix: Fixed wrong date format when language is set to Default Jan 26, 2023
@yaira2 yaira2 requested a review from gave92 January 26, 2023 22:32
Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Jan 31, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2
Copy link
Member

yaira2 commented Feb 1, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2
Copy link
Member

yaira2 commented Feb 1, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2
Copy link
Member

yaira2 commented Feb 1, 2023

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yaira2
Copy link
Member

yaira2 commented Feb 1, 2023

CI pipeline is having some issues

@yaira2 yaira2 merged commit ce26b20 into files-community:main Feb 1, 2023
@hishitetsu hishitetsu deleted the DefaultDateTimeFormat branch February 2, 2023 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add locale to others languages on creation date and modified date
3 participants