Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added bitrate info for audio files in properties windows #11051

Merged
merged 13 commits into from
Jan 29, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 changed the title Fix: Format bitrate with its units Feature: Added bitrate info for audio files in properties windows Jan 22, 2023
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small formatting, but works as intended for me.

src/Files.App/ViewModels/Properties/FileProperties.cs Outdated Show resolved Hide resolved
src/Files.App/ViewModels/Properties/FileProperties.cs Outdated Show resolved Hide resolved
QuaintMako
QuaintMako previously approved these changes Jan 22, 2023
@yaira2 yaira2 requested a review from d2dyno1 January 24, 2023 16:43
d2dyno1
d2dyno1 previously approved these changes Jan 24, 2023
@d2dyno1 d2dyno1 requested a review from yaira2 January 27, 2023 19:33
yaira2
yaira2 previously approved these changes Jan 27, 2023
@yaira2 yaira2 dismissed stale reviews from d2dyno1, QuaintMako, and themself via 6346691 January 29, 2023 18:37
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 29, 2023
@yaira2 yaira2 merged commit 688a8a2 into files-community:main Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add bitrate info for audio files in properties windows
4 participants