Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Fixed create file button when entering text with Chinese input flyout #11040

Merged
merged 32 commits into from
Jan 22, 2023
Merged

Fix: Fixed create file button when entering text with Chinese input flyout #11040

merged 32 commits into from
Jan 22, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

hecksmosis and others added 16 commits January 9, 2023 18:34
@yaira2 yaira2 changed the title Fix: Fix chinese input flyout not enabling button Fix: Fixed create file button when entering text with Chinese input flyout Jan 19, 2023
yaira2
yaira2 previously approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@yaira2 yaira2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 requested a review from QuaintMako January 22, 2023 01:25
@jiejasonliu
Copy link
Contributor

this change will regress #7967, just wanted to point out if we're okay with that

@yaira2
Copy link
Member

yaira2 commented Jan 22, 2023

this change will regress #7967, just wanted to point out if we're okay with that

Thanks for the heads up, this is okay.

QuaintMako
QuaintMako reviewed Jan 22, 2023
View reviewed changes
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should be the last bit I can squeeze by being picky. LGTM otherwise.

src/Files.App/Helpers/DynamicDialogFactory.cs Outdated Show resolved Hide resolved
@yaira2 yaira2 requested a review from QuaintMako January 22, 2023 16:27
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 22, 2023
@yaira2 yaira2 merged commit 030cd41 into files-community:main Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@QuaintMako QuaintMako Awaiting requested review from QuaintMako

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Create file button is disabled when using Chinese input flyout
4 participants
@hecksmosis @jiejasonliu @yaira2 @QuaintMako