Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase: Refactored themes #11031

Merged
merged 3 commits into from
Jan 17, 2023
Merged

Codebase: Refactored themes #11031

merged 3 commits into from
Jan 17, 2023

Conversation

yaira2
Copy link
Member

@yaira2 yaira2 commented Jan 17, 2023

Resolved / Related Issues

  • Switched property in view model and resource factory to string. This accounts for empty strings which indicate the default value. If we didn't use blank strings to indicate default, we'd have to provide a separate value for light and dark mode.
  • Added LoadAppResources method to AppThemeResourcesHelper
  • Call LoadAppResources from the ViewModel instead of the View.

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots (optional)
Add screenshots here.

@yaira2 yaira2 requested a review from jiejasonliu January 17, 2023 16:10
@yaira2 yaira2 merged commit be3288b into main Jan 17, 2023
@yaira2 yaira2 deleted the ya/OptThemes branch January 17, 2023 20:24
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants