Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Added support for installing multiple fonts at the same time #11029

Merged
merged 14 commits into from
Jan 18, 2023

Conversation

hecksmosis
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Validation
How did you test these changes?

  • Built and ran the app

@hecksmosis hecksmosis changed the title feature: Add support for installing multiple fonts at a time Feature: Add support for installing multiple fonts at a time Jan 16, 2023
@yaira2 yaira2 changed the title Feature: Add support for installing multiple fonts at a time Feature: Added support for installing multiple fonts at the same time Jan 16, 2023
QuaintMako
QuaintMako previously approved these changes Jan 16, 2023
Copy link
Contributor

@QuaintMako QuaintMako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion, LGTM and works on my machine.

src/Files.App/Helpers/ShellContextMenuHelper.cs Outdated Show resolved Hide resolved
@yaira2
Copy link
Member

yaira2 commented Jan 18, 2023

@hecksmosis if you're okay with my changes, LGTM.

@hecksmosis
Copy link
Contributor Author

Ok

@hecksmosis
Copy link
Contributor Author

hecksmosis commented Jan 18, 2023

(I actually was making them on my machine, but you beat me to it)

@hecksmosis
Copy link
Contributor Author

I think this is done then

@yaira2 yaira2 merged commit 7cd9e84 into files-community:main Jan 18, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Support for installing multiple fonts at the same time
4 participants