Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Added shortcut for opening folders in secondary pane #10966

Merged
merged 10 commits into from
Jan 16, 2023
Merged

Feature: Added shortcut for opening folders in secondary pane #10966

merged 10 commits into from
Jan 16, 2023

Conversation

QuaintMako
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

What has been done

  • Made the process to open a folder in the dual pane into a method inside NavigationHelpers.
  • Added the keyboard accelerator to both Grid View and Details View. (Not in Column View).
  • Added a null check in FileList_PreviewKeyDown for each view.
  • Fixed the missing icon on the flyout menu to open in dual pane option. (Used the one from the Settings)

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

Screenshots

With icon:
IconFlyoutMenu

Without icon:
image

@QuaintMako QuaintMako changed the title 10907 secondary pane accelerator Feature: Folders can now be opened in secondary pane with Keyboard Accelerator (Ctrl+Shift+Enter) Jan 9, 2023
@hecksmosis
Copy link
Contributor

hecksmosis commented Jan 10, 2023 •
edited
Loading

Aside from that LGTM and works for me

@QuaintMako
Copy link
Contributor Author

Aside from that LGTM and works for me

Aside from? I suppose your review did not get through.

@hecksmosis
Copy link
Contributor

hecksmosis commented Jan 11, 2023 •
edited
Loading

Wouldn't it be better to rename the function to OpenInSecondaryPane for consistency? (NavigationHelpers.cs line 40)

@yaira2 yaira2 requested a review from d2dyno1 January 15, 2023 17:37
@yaira2 yaira2 added changes requested Changes are needed for this pull request and removed needs - code review labels Jan 15, 2023
ferrariofilippo
ferrariofilippo approved these changes Jan 15, 2023
View reviewed changes
Copy link
Contributor

@ferrariofilippo ferrariofilippo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaira2 yaira2 added needs - code review and removed changes requested Changes are needed for this pull request labels Jan 15, 2023
@yaira2 yaira2 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Jan 16, 2023
@yaira2 yaira2 changed the title Feature: Folders can now be opened in secondary pane with Keyboard Accelerator (Ctrl+Shift+Enter) Feature: Added shortcut for opening folders in secondary pane Jan 16, 2023
@yaira2 yaira2 merged commit 81d9e3d into files-community:main Jan 16, 2023
@QuaintMako QuaintMako deleted the 10907_SecondaryPaneAccelerator branch February 28, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaira2 yaira2 yaira2 approved these changes

@ferrariofilippo ferrariofilippo ferrariofilippo approved these changes

@d2dyno1 d2dyno1 d2dyno1 approved these changes

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Shortcut to open selected folder in Secondary Pane
5 participants
@QuaintMako @hecksmosis @yaira2 @d2dyno1 @ferrariofilippo