Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code quality: Refactoring and improvements #10948

Merged
merged 27 commits into from
Feb 3, 2023
Merged

Code quality: Refactoring and improvements #10948

merged 27 commits into from
Feb 3, 2023

Conversation

ferrariofilippo
Copy link
Contributor

Resolved / Related Issues
Items resolved / related issues by this PR.

Details
This PR contains a partial refactoring of our code base. Here's the change-list:

  • Removed nullable warnings (verifying that variables are null checked)
  • Removed unused parameters from methods
  • Removed some avoidable if-else branches
  • Created methods for code that can be reused

Validation
How did you test these changes?

  • Built and ran the app
  • Tested the changes for accessibility

QuaintMako
QuaintMako previously approved these changes Jan 20, 2023
View reviewed changes
hecksmosis
hecksmosis previously approved these changes Jan 22, 2023
View reviewed changes
@ferrariofilippo ferrariofilippo dismissed stale reviews from hecksmosis and QuaintMako via a9ed779 January 29, 2023 20:14
@yaira2 yaira2 requested review from gave92 and QuaintMako January 29, 2023 20:26
@yaira2 yaira2 requested a review from hecksmosis January 29, 2023 20:26
@yaira2 yaira2 changed the title Code quality: codebase refactoring Code quality: Refactoring and improvements Jan 29, 2023
hecksmosis
hecksmosis previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@hecksmosis hecksmosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

QuaintMako
QuaintMako previously approved these changes Jan 30, 2023
View reviewed changes
@yaira2
Copy link
Member

yaira2 commented Feb 2, 2023

@ferrariofilippo can you resolve the merge conflicts?

@ferrariofilippo ferrariofilippo dismissed stale reviews from QuaintMako and hecksmosis via 4b403ae February 2, 2023 18:04
hecksmosis
hecksmosis previously approved these changes Feb 2, 2023
View reviewed changes
@d2dyno1
Copy link
Member

d2dyno1 commented Feb 3, 2023

One more conflict 👀

@d2dyno1 d2dyno1 added ready to merge Pull requests that are approved and ready to merge and removed needs - code review labels Feb 3, 2023
@yaira2 yaira2 merged commit 2f4bce7 into files-community:main Feb 3, 2023
@ferrariofilippo ferrariofilippo deleted the Code_Refactoring branch February 3, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hecksmosis hecksmosis hecksmosis approved these changes

@d2dyno1 d2dyno1 d2dyno1 approved these changes

@QuaintMako QuaintMako QuaintMako left review comments

@gave92 gave92 Awaiting requested review from gave92

Assignees
No one assigned
Labels
ready to merge Pull requests that are approved and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ferrariofilippo @yaira2 @d2dyno1 @gave92 @hecksmosis @QuaintMako